From: Teresa Remmet <t.remmet@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH 43/62] UBI: Fastmap: Fall back to scanning mode after ECC error
Date: Mon, 23 May 2016 10:26:31 +0200 [thread overview]
Message-ID: <1463992010-31537-44-git-send-email-t.remmet@phytec.de> (raw)
In-Reply-To: <1463992010-31537-1-git-send-email-t.remmet@phytec.de>
From: Richard Weinberger <richard@nod.at>
If we encounter an uncorrectable ECC error while scanning for the fastmap
UBI must not fail hard. Instead fall back to scanning mode.
Reported-by: Alexander Block <Alexander.Block@continental-corporation.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Conflicts:
drivers/mtd/ubi/attach.c
Fixed minor conflict.
Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
drivers/mtd/ubi/attach.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
index dc14a2b..b49842b 100644
--- a/drivers/mtd/ubi/attach.c
+++ b/drivers/mtd/ubi/attach.c
@@ -1390,7 +1390,7 @@ int ubi_attach(struct ubi_device *ubi, int force_scan)
err = scan_all(ubi, ai, 0);
else {
err = scan_fast(ubi, ai);
- if (err > 0) {
+ if (err > 0 || mtd_is_eccerr(err)) {
if (err != UBI_NO_FASTMAP) {
destroy_ai(ai);
ai = alloc_ai("ubi_aeb_slab_cache2");
--
1.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-05-23 8:28 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 8:25 [PATCH 00/62] Update UBI Teresa Remmet
2016-05-23 8:25 ` [PATCH 01/62] UBI: add missing kmem_cache_free() in process_pool_aeb error path Teresa Remmet
2016-05-23 8:25 ` [PATCH 02/62] UBI: Improve comment on work_sem Teresa Remmet
2016-05-23 8:25 ` [PATCH 03/62] UBI: ubi_eba_read_leb: Remove in vain variable assignment Teresa Remmet
2016-05-23 8:25 ` [PATCH 04/62] UBI: wl: Rename cancel flag to shutdown Teresa Remmet
2016-05-23 8:25 ` [PATCH 05/62] UBI: Fix trivial typo in __schedule_ubi_work Teresa Remmet
2016-05-23 8:25 ` [PATCH 06/62] UBI: Fastmap: Calc fastmap size correctly Teresa Remmet
2016-05-23 8:25 ` [PATCH 07/62] UBI: Extend UBI layer debug/messaging capabilities Teresa Remmet
2016-05-23 8:25 ` [PATCH 08/62] UBI: vtbl: Use ubi_eba_atomic_leb_change() Teresa Remmet
2016-05-23 8:25 ` [PATCH 09/62] UBI: Fix double free after do_sync_erase() Teresa Remmet
2016-05-23 8:25 ` [PATCH 10/62] UBI: Fix invalid vfree() Teresa Remmet
2016-05-23 8:25 ` [PATCH 11/62] UBI: extend UBI layer debug/messaging capabilities - cosmetics Teresa Remmet
2016-05-23 8:26 ` [PATCH 12/62] UBI: clean-up printing helpers Teresa Remmet
2016-05-23 8:26 ` [PATCH 13/62] UBI: do propagate positive error codes up Teresa Remmet
2016-05-23 8:26 ` [PATCH 14/62] UBI: Fastmap: Care about the protection queue Teresa Remmet
2016-05-23 8:26 ` [PATCH 15/62] UBI: fix missing brace control flow Teresa Remmet
2016-05-23 8:26 ` [PATCH 16/62] UBI: account for bitflips in both the VID header and data Teresa Remmet
2016-05-23 8:26 ` [PATCH 17/62] UBI: fix out of bounds write Teresa Remmet
2016-05-23 8:26 ` [PATCH 18/62] UBI: initialize LEB number variable Teresa Remmet
2016-05-23 8:26 ` [PATCH 19/62] UBI: align comment for readability Teresa Remmet
2016-05-23 8:26 ` [PATCH 20/62] UBI: Split __wl_get_peb() Teresa Remmet
2016-05-23 8:26 ` [PATCH 21/62] UBI: Fastmap: Make ubi_refill_pools() fair Teresa Remmet
2016-05-23 8:26 ` [PATCH 22/62] UBI: Fastmap: Don't allocate new ubi_wl_entry objects Teresa Remmet
2016-05-23 8:26 ` [PATCH 23/62] UBI: Fastmap: Fix memory leaks while closing the WL sub-system Teresa Remmet
2016-05-23 8:26 ` [PATCH 24/62] UBI: Fastmap: Notify user in case of an ubi_update_fastmap() failure Teresa Remmet
2016-05-23 8:26 ` [PATCH 25/62] UBI: Fastmap: Wrap fastmap specific function in a ifdef Teresa Remmet
2016-05-23 8:26 ` [PATCH 26/62] UBI: Fastmap: Fix fastmap usage in ubi_volume_notify() Teresa Remmet
2016-05-23 8:26 ` [PATCH 27/62] UBI: Fastmap: Fix race in ubi_eba_atomic_leb_change() Teresa Remmet
2016-05-23 8:26 ` [PATCH 28/62] UBI: Fastmap: Remove bogus ubi_assert() Teresa Remmet
2016-05-23 8:26 ` [PATCH 29/62] UBI: Fastmap: Remove eba_orphans logic Teresa Remmet
2016-05-23 8:26 ` [PATCH 30/62] UBI: Fastmap: Switch to ro mode if invalidate_fastmap() fails Teresa Remmet
2016-05-23 8:26 ` [PATCH 31/62] UBI: Fastmap: Make WL pool size 50% of user pool size Teresa Remmet
2016-05-23 8:26 ` [PATCH 32/62] UBI: Fastmap: Fix leb_count unbalance Teresa Remmet
2016-05-23 8:26 ` [PATCH 33/62] UBI: Fastmap: Set used_ebs only for static volumes Teresa Remmet
2016-05-23 8:26 ` [PATCH 34/62] UBI: Fastmap: Prepare for variable sized fastmaps Teresa Remmet
2016-05-23 8:26 ` [PATCH 35/62] UBI: Fastmap: Rework fastmap error paths Teresa Remmet
2016-05-23 8:26 ` [PATCH 36/62] UBI: Fix stale pointers in ubi->lookuptbl Teresa Remmet
2016-05-23 8:26 ` [PATCH 37/62] UBI: Move fastmap specific functions out of wl.c Teresa Remmet
2016-05-23 8:26 ` [PATCH 38/62] UBI: Add accessor functions for WL data structures Teresa Remmet
2016-05-23 8:26 ` [PATCH 39/62] UBI: Fastmap: Wire up WL accessor functions Teresa Remmet
2016-05-23 8:26 ` [PATCH 40/62] UBI: Fastmap: Introduce ubi_fastmap_init() Teresa Remmet
2016-05-23 8:26 ` [PATCH 41/62] UBI: Fastmap: Introduce may_reserve_for_fm() Teresa Remmet
2016-05-23 8:26 ` [PATCH 42/62] UBI: Fastmap: Remove is_fm_block() Teresa Remmet
2016-05-23 8:26 ` Teresa Remmet [this message]
2016-05-23 8:26 ` [PATCH 44/62] UBI: Fastmap: Use max() to get the larger value Teresa Remmet
2016-05-23 8:26 ` [PATCH 45/62] UBI: Fastmap: Remove unnecessary `\' Teresa Remmet
2016-05-23 8:26 ` [PATCH 46/62] UBI: Fastmap: Rename variables to make them meaningful Teresa Remmet
2016-05-23 8:26 ` [PATCH 47/62] UBI: Init vol->reserved_pebs by assignment Teresa Remmet
2016-05-23 8:26 ` [PATCH 48/62] UBI: Fastmap: Do not add vol if it already exists Teresa Remmet
2016-05-23 8:26 ` [PATCH 49/62] UBI: add a helper function for updatting on-flash layout volumes Teresa Remmet
2016-05-23 8:26 ` [PATCH 50/62] UBI: Remove unnecessary `\' Teresa Remmet
2016-05-23 8:26 ` [PATCH 51/62] UBI: Validate data_size Teresa Remmet
2016-05-23 8:26 ` [PATCH 52/62] UBI: return ENOSPC if no enough space available Teresa Remmet
2016-05-23 8:26 ` [PATCH 53/62] UBI: Fastmap: Simplify expression Teresa Remmet
2016-05-23 8:26 ` [PATCH 54/62] UBI: Fix typo in comment Teresa Remmet
2016-05-23 8:26 ` [PATCH 55/62] UBI: Fix debug message Teresa Remmet
2016-05-23 8:26 ` [PATCH 56/62] UBI: Fastmap: Fix PEB array type Teresa Remmet
2016-05-23 8:26 ` [PATCH 57/62] UBI: fix use of "VID" vs. "EC" in header self-check Teresa Remmet
2016-05-23 8:26 ` [PATCH 58/62] mtd: ubi: fixup error correction in do_sync_erase() Teresa Remmet
2016-05-23 8:26 ` [PATCH 59/62] mtd: ubi: don't leak e if schedule_erase() fails Teresa Remmet
2016-05-23 8:26 ` [PATCH 60/62] mtd: ubi: wl: avoid erasing a PEB which is empty Teresa Remmet
2016-05-23 8:26 ` [PATCH 61/62] ubi: Fix out of bounds write in volume update code Teresa Remmet
2016-05-23 8:26 ` [PATCH 62/62] mtd: UBI: Remove ubi_free_fastmap Teresa Remmet
2016-05-25 7:29 ` [PATCH 00/62] Update UBI Sascha Hauer
2016-05-25 11:38 ` Teresa Remmet
2016-05-25 13:33 ` Robert Schwebel
2016-05-25 14:42 ` Teresa Remmet
2016-05-25 14:54 ` Robert Schwebel
2016-05-25 20:22 ` Sam Ravnborg
2016-05-27 7:26 ` Teresa Remmet
2016-05-26 17:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463992010-31537-44-git-send-email-t.remmet@phytec.de \
--to=t.remmet@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox