From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org,
Jonas Richardsen <jonasrichardsen@emlix.com>
Subject: Re: [PATCH v2] of: do not copy properties if they already exist in the destination
Date: Tue, 16 Apr 2024 15:38:28 +0200 [thread overview]
Message-ID: <171327470825.2032048.4263920005460022049.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240415122757.327312-1-jonasrichardsen@emlix.com>
On Mon, 15 Apr 2024 14:26:04 +0200, Jonas Richardsen wrote:
> Currently `of_copy_property` copies the given property even if a property
> with the same name already exists on the destination node.
> This leads to kernel warnings about duplicate properties:
> ```
> [ 0.014063] Duplicate name in chosen, renamed to "stdout-path#1"
> [ 0.014093] Duplicate name in chosen, renamed to "bootargs#1"
> [ 0.014119] Duplicate name in chosen, renamed to "phandle#1"
> [ 0.014197] Duplicate name in reserved-memory, renamed to "#address-cells#1"
> [ 0.014226] Duplicate name in reserved-memory, renamed to "#size-cells#1"
> [ 0.014252] Duplicate name in reserved-memory, renamed to "ranges#1"
> [ 0.014278] Duplicate name in reserved-memory, renamed to "phandle#1"
> ```
> Therefore, the function was changed to return an error if the property
> already exists in the destination.
> The change does not cause any regressions, because the only usage of
> this function occurs within `arch/arm/boards/raspberry-pi/rpi-common.c`
> where the original behaviour of the function is obviously unintended.
>
> [...]
Applied, thanks!
[1/1] of: do not copy properties if they already exist in the destination
https://git.pengutronix.de/cgit/barebox/commit/?id=364a1831678d (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-04-16 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 9:59 raspi: should vc fixups update properties of existing nodes? Jonas Richardsen
2024-04-10 11:51 ` Ahmad Fatoum
2024-04-15 8:14 ` [PATCH] of: do not copy properties if they already exist in the destination Jonas Richardsen
2024-04-15 8:30 ` Ahmad Fatoum
2024-04-15 12:26 ` [PATCH v2] " Jonas Richardsen
2024-04-16 13:38 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171327470825.2032048.4263920005460022049.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jonasrichardsen@emlix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox