From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Fabian Pfitzner <f.pfitzner@pengutronix.de>
Subject: Re: [PATCH] state: guard against empty variable set in DT
Date: Tue, 04 Nov 2025 09:34:12 +0100 [thread overview]
Message-ID: <176224525216.2210227.12703093461803019037.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20251103111624.1848136-1-a.fatoum@pengutronix.de>
On Mon, 03 Nov 2025 12:16:23 +0100, Ahmad Fatoum wrote:
> We always initialize state->variables, but there are two places in the
> code that assume there is at least one entry already.
>
> Change them to use list_first_entry_or_null/list_last_entry_or_null as
> appropriate to catch this issue gracefully.
>
> This should have only affected state nodes without children, which is
> not a useful device tree description, but nevertheless we should handle
> that somehow instead of reading uninitialized values that may trigger
> a panic or other misbehavior.
>
> [...]
Applied, thanks!
[1/1] state: guard against empty variable set in DT
https://git.pengutronix.de/cgit/barebox/commit/?id=f1b549a97e50 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-11-04 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 11:16 Ahmad Fatoum
2025-11-04 8:34 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176224525216.2210227.12703093461803019037.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=f.pfitzner@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox