From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 23 Apr 2024 08:22:44 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rz9YC-00CX5F-2d for lore@lore.pengutronix.de; Tue, 23 Apr 2024 08:22:44 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rz9YC-0003Om-7l for lore@pengutronix.de; Tue, 23 Apr 2024 08:22:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=lX5uN4Fvrou/xsHdrzyyoSFwb+x514PBkz+n7t30DMs=; b=AfVeLYXUAiaOkq132UK2PBkIYs vG1Trsjn4n7DBfjhKWPOizpiEFkK913/9h9dJ9aeDov37WlwmVVerM0lrq1Q5ACh+hLPQkzcT1bVk 5lNt2oEX+kyHTfnFpaUYwtkss6A4gF1RgJHSUyPIA9g0nyoYhmG7K1fsEI6+KvfB0hc1HZWqwyGGN /lRUmCBNNktbMdiWaScRnQUQr+6kt/nLd0sySxf2JbzqeJH8YI1EnBz8iFKrRQNOoEIf5n/qODBxF xqEtDEtZ4LZdApRJzJPDQ/Q+ZpqTSUHWIGuqwjDDQGa4aRQrgOMTRjlu3LntS59xJTXOf0yjgFtee OQq6Pw4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz9Xh-0000000G7dj-2ts4; Tue, 23 Apr 2024 06:22:13 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz9Xe-0000000G7cL-0GKC for barebox@lists.infradead.org; Tue, 23 Apr 2024 06:22:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rz9Xc-00039M-5C; Tue, 23 Apr 2024 08:22:08 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rz9Xb-00DpNj-Ow; Tue, 23 Apr 2024 08:22:07 +0200 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1rz9Xb-006N1q-2C; Tue, 23 Apr 2024 08:22:07 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: str@pengutronix.de, mtr@pengutronix.de, Ahmad Fatoum Date: Tue, 23 Apr 2024 08:22:04 +0200 Message-Id: <20240423062206.1518464-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_232210_170123_7D75231F X-CRM114-Status: UNSURE ( 9.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.4 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master 1/3] mci: core: fix fallback when eMMC DDR52 is not possible X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) mci_mmc_select_hs_ddr() will try DDR52 and if that fails, revert to SDR operation. In that case, it returns the bus width, which would be forwarded as if it were an error code: WARNING: mmc2: Card's startup fails with 3 Fix this by translating successful return values to 0 in mci_startup_mmc(). Signed-off-by: Ahmad Fatoum --- drivers/mci/mci-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c index 1d383e6449e9..57b4c5b99c9c 100644 --- a/drivers/mci/mci-core.c +++ b/drivers/mci/mci-core.c @@ -1566,7 +1566,7 @@ static int mci_startup_mmc(struct mci *mci) } } - return ret; + return ret >= MMC_BUS_WIDTH_1 ? 0 : ret; } /** -- 2.39.2