Re: [PATCH v2 2/2] ARM: boards: i.MX93: Add NXP FRDM i.MX93 support

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Oct 21, 2025 at 01:11:46PM +0200, Ahmad Fatoum wrote:
> > +static noinline void frdm_imx93_continue(void)
> > +{
> > +	void __iomem *base = IOMEM(MX9_UART1_BASE_ADDR);
> > +	void __iomem *muxbase = IOMEM(MX9_IOMUXC_BASE_ADDR);
> > +
> > +	/* configure LPUART1 TX pin */
> > +	writel(0x0, muxbase + 0x184);
> > +
> > +	imx9_uart_setup(base);
> > +	pbl_set_putc(lpuart32_putc, base + 0x10);
> > +	putchar('>');
> 
> Do you see the > character on bootup if CONFIG_PBL_CONSOLE is enabled?
> Maud (Cc'd) mentioned on the IRC that the 0x10 offset shouldn't be
> necessary.

The UART register space starts at offset 0x10 from the base address.
Some Layerscape SoCs use the same lpuart implementation without this
offset (although barebox doesn't have support for these Layerscape
SoCs).

Maybe we could add a

static inline void imx93_uart_putc(void __iomem *base)
{
	lpuart32_putc(base + 0x10);
}

to avoid confusion.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |