RE: [PATCH] import linux __iowrite32/64_copy support

From: "Marc Reilly" <marc@cpdesign.com.au>
To: 'Jean-Christophe PLAGNIOL-VILLARD' <plagnioj@jcrosoft.com>,
	barebox@lists.infradead.org
Subject: RE: [PATCH] import linux __iowrite32/64_copy support
Date: Fri, 3 Jun 2011 17:02:54 +1000	[thread overview]
Message-ID: <001801cc21bc$4677db10$d3679130$@cpdesign.com.au> (raw)
In-Reply-To: <1307029887-7091-1-git-send-email-plagnioj@jcrosoft.com>

Hi,

<snip>

> +/**
> + * __iowrite64_copy - copy data to MMIO space, in 64-bit or 32-bit
> +units
> + * @to: destination, in MMIO space (must be 64-bit aligned)
> + * @from: source (must be 64-bit aligned)
> + * @count: number of 64-bit quantities to copy
> + *
> + * Copy data from kernel space to MMIO space, in units of 32 or 64 bits
> +at a
> + * time.  Order of access is not guaranteed, nor is a memory barrier
> + * performed afterwards.
> + */
> +void __attribute__((weak)) __iowrite64_copy(void __iomem *to,
> +					    const void *from,
> +					    size_t count)
> +{
> +#ifdef CONFIG_64BIT
> +	u64 __iomem *dst = to;
> +	const u64 *src = from;
> +	const u64 *end = src + count;
> +
> +	while (src < end)
> +		__raw_writeq(*src++, dst++);
> +#else
> +	__iowrite32_copy(to, from, count * 2); #endif }
> +
> +EXPORT_SYMBOL_GPL(__iowrite64_copy);
> --

Is this missing #endif  for CONFIG_64BIT ?

Cheers
Marc

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox