mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands/splash: fix '-y' option handling
Date: Mon, 26 Jan 2015 16:51:14 +0800	[thread overview]
Message-ID: <0085328D-B349-4555-BB8A-7E6EE36D9A96@jcrosoft.com> (raw)
In-Reply-To: <1422192133-17906-1-git-send-email-antonynpavlov@gmail.com>


> On Jan 25, 2015, at 9:22 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> 
> The '-y' and '-o' options are independent,
> so just add missing 'break'.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> commands/splash.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/commands/splash.c b/commands/splash.c
> index 9bd84fb..077c0e4 100644
> --- a/commands/splash.c
> +++ b/commands/splash.c
> @@ -41,6 +41,7 @@ static int do_splash(int argc, char *argv[])
> 			break;
> 		case 'y':
> 			s.y = simple_strtoul(optarg, NULL, 0);
> +			break;
> 		case 'o':
> 			offscreen = 1;
> 		}
> -- 
> 2.1.4

I already send a patch weeks ago to fix

Best Regards,
J.
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2015-01-26  8:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 13:22 Antony Pavlov
2015-01-26  8:16 ` Sascha Hauer
2015-01-26  8:51 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2015-01-26  9:22   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0085328D-B349-4555-BB8A-7E6EE36D9A96@jcrosoft.com \
    --to=plagnioj@jcrosoft.com \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox