From: "Andy Pont" <andy.pont@sdcsystems.com>
To: 'Sascha Hauer' <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: RE: [PATCH 04/11] include support for a simple pseudo number generator
Date: Thu, 17 Jun 2010 14:26:58 +0100 [thread overview]
Message-ID: <00e901cb0e20$c3d5eb70$4b81c250$@pont@sdcsystems.com> (raw)
In-Reply-To: <20100617131724.GN20799@pengutronix.de>
Sascha Hauer wrote...
> +#define RAND_MAX 32767
> +
> +/* return a pseudo-random integer in the range [0, RAND_MAX] */
> +unsigned int rand(void);
*Snip*
> +unsigned int rand(void)
> +{
> + random_seed = random_seed * 1103515245 + 12345;
> + return (random_seed / 65536) % 32768;
> +}
The return value on this function seems wrong as it will always return a
value between 0 and 32767 irrespective of what RAND_MAX is set to which
doesn't agree with the comment on the function prototype.
Although it may just be me being dim as my hayfever is driving me mad today
:-)
A.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-06-17 13:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 9:48 More patches Sascha Hauer
2010-06-14 9:48 ` [PATCH 01/11] pcm037: Add MMU support Sascha Hauer
2010-06-14 9:48 ` [PATCH 02/11] bootu: Allow passing in devices as parameter Sascha Hauer
2010-06-14 9:48 ` [PATCH 03/11] Allow to merge default environment from more than one directory Sascha Hauer
2010-06-14 9:48 ` [PATCH 04/11] include support for a simple pseudo number generator Sascha Hauer
2010-06-15 9:39 ` Peter Korsgaard
2010-06-15 11:54 ` Sascha Hauer
2010-06-17 13:17 ` Sascha Hauer
2010-06-17 13:26 ` Andy Pont [this message]
2010-06-17 14:14 ` Peter Korsgaard
2010-06-14 9:48 ` [PATCH 05/11] net: implement random_ether_addr Sascha Hauer
2010-06-14 9:48 ` [PATCH 06/11] net: use a random mac address if the current device does not have one Sascha Hauer
2010-06-14 9:48 ` [PATCH 07/11] add a generic default environment Sascha Hauer
2010-06-15 9:13 ` Uwe Kleine-König
2010-06-17 13:20 ` Sascha Hauer
2010-06-19 20:14 ` Uwe Kleine-König
2010-06-14 9:48 ` [PATCH 08/11] pcm038: use generic default env Sascha Hauer
2010-06-14 9:48 ` [PATCH 09/11] pcm043: " Sascha Hauer
2010-06-14 9:48 ` [PATCH 10/11] pcm037: " Sascha Hauer
2010-06-14 9:48 ` [PATCH 11/11] pca100: " Sascha Hauer
2010-06-18 6:28 [PATCH 04/11] include support for a simple pseudo number generator 'Sascha Hauer'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00e901cb0e20$c3d5eb70$4b81c250$@pont@sdcsystems.com' \
--to=andy.pont@sdcsystems.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox