From: "Marc Reilly" <marc@cpdesign.com.au>
To: 'Sascha Hauer' <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: RE: V3 patches for imx35pdk boot
Date: Mon, 17 May 2010 21:16:08 +1000 [thread overview]
Message-ID: <013401caf5b2$5c443c40$14ccb4c0$@cpdesign.com.au> (raw)
In-Reply-To: <20100517090416.GK31199@pengutronix.de>
Hi,
> > Third time's a charm, hopefully. I fixed up all the whitespace issues
> > in 3stack.c and signed off all the patches.
>
> There are still some trailing whitespaces left. I killed them while
committing.
Sorry, and thanks. I just had a quick scan through the patches that I
emailed and I swear I'd taken care of them...
> > The morale of the story is get it right first go :) (I'm not too sure
> > how to combine patch 1 and 2, and being such a git newb my tree is
> > already starting to look like a pair of octopi mating, so I'm just
> > going to leave as is.)
>
> Have a look at git rebase -i, it's really nice ;)
That's what I found in the end. The original morale of the story still
stands though.
People should also note that the LCD and IPU remains enabled as the kernel
goes through its initialization. When the IPU is probed/initialized
(somewhere in ipu_common.c) the IRQ is enabled (and then immediately
disabled after the function returns) before all the data structures are
properly setup. Because the IPU is still enabled the interrupt fires before
the init finishes and the kernel crashes.
TL;DR: either the ipu init in the kernel needs to be tweaked, or turned off
in barebox before boot.
Cheers
Marc
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2010-05-17 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 2:15 Marc Reilly
2010-05-14 2:15 ` [PATCH 1/5] arm: Add revision tag to boot parameters Marc Reilly
2010-05-14 2:15 ` [PATCH 2/5] arm boot: Formatting Marc Reilly
2010-05-14 2:15 ` [PATCH 3/5] imx35: add detection of silicon revision Marc Reilly
2010-05-14 2:15 ` [PATCH 4/5] imx35pdk: correct mode for display contrast pin Marc Reilly
2010-05-14 2:15 ` [PATCH 5/5] imx35pdk: Detect and set silicon and board revision for boot params Marc Reilly
2010-05-17 9:04 ` V3 patches for imx35pdk boot Sascha Hauer
2010-05-17 11:16 ` Marc Reilly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='013401caf5b2$5c443c40$14ccb4c0$@cpdesign.com.au' \
--to=marc@cpdesign.com.au \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox