i2c: Rockchip i2c controller support

i2c: Rockchip i2c controller support

[Matthias Fend]

Hi,

it looks to me like the rockchip_i2c_xfer function returns 0 if 
everything was successful, but shouldn't the i2c master_xfer functions 
return the number of messages actually processed?

I was just wondering about reading sources and can't do real world 
testing due to lack of hardware...

  ~Matthias

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: i2c: Rockchip i2c controller support

[Ahmad Fatoum]

Hello Matthias,

On 03.05.22 12:11, Matthias Fend wrote:
> Hi,
> 
> it looks to me like the rockchip_i2c_xfer function returns 0 if everything was successful, but shouldn't the i2c master_xfer functions return the number of messages actually processed?
> 
> I was just wondering about reading sources and can't do real world testing due to lack of hardware...

I think you're right. I tested this only with the RK808 PMIC on the Nano Pi N10
and noticed no problems, but it seems that was just me being lucky.

I'll give it a test with fixed return value and send a patch in the
coming days.

Thanks for the review!

Cheers,
Ahmad

> 
>  ~Matthias
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox