* i.MX53 - add WEIM register defines
@ 2013-02-08 19:05 George Pontis
2013-02-08 19:20 ` Alexander Shiyan
0 siblings, 1 reply; 3+ messages in thread
From: George Pontis @ 2013-02-08 19:05 UTC (permalink / raw)
To: barebox
Subject: i.MX53: Add WEIM register defines ( same as i.MX51 )
Signed-off-by: George Pontis <gpontis@spamcop.net>
diff -Naur bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h
bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h
--- bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-04
06:24:51.000000000 -0800
+++ bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-06
23:14:45.982747680 -0800
@@ -1,6 +1,17 @@
#ifndef __MACH_IMX53_REGS_H
#define __MACH_IMX53_REGS_H
+/* WEIM registers */
+#define WEIM_CSxGCR1(n) (((n) * 0x18) + 0x00)
+#define WEIM_CSxGCR2(n) (((n) * 0x18) + 0x04)
+#define WEIM_CSxRCR1(n) (((n) * 0x18) + 0x08)
+#define WEIM_CSxRCR2(n) (((n) * 0x18) + 0x0c)
+#define WEIM_CSxWCR1(n) (((n) * 0x18) + 0x10)
+#define WEIM_CSxWCR2(n) (((n) * 0x18) + 0x14)
+#define WEIM_WCR 0x90
+#define WEIM_WIAR 0x94
+#define WEIM_EAR 0x98
+
#define MX53_IROM_BASE_ADDR 0x0
#define MX53_SATA_BASE_ADDR 0x10000000
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: i.MX53 - add WEIM register defines
2013-02-08 19:05 i.MX53 - add WEIM register defines George Pontis
@ 2013-02-08 19:20 ` Alexander Shiyan
2013-02-11 9:12 ` Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Shiyan @ 2013-02-08 19:20 UTC (permalink / raw)
To: George Pontis; +Cc: barebox
> Subject: i.MX53: Add WEIM register defines ( same as i.MX51 )
>
> Signed-off-by: George Pontis <gpontis@spamcop.net>
>
> diff -Naur bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h
> bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h
> --- bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-04
> 06:24:51.000000000 -0800
> +++ bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-06
> 23:14:45.982747680 -0800
> @@ -1,6 +1,17 @@
> #ifndef __MACH_IMX53_REGS_H
> #define __MACH_IMX53_REGS_H
>
> +/* WEIM registers */
> +#define WEIM_CSxGCR1(n) (((n) * 0x18) + 0x00)
> +#define WEIM_CSxGCR2(n) (((n) * 0x18) + 0x04)
> +#define WEIM_CSxRCR1(n) (((n) * 0x18) + 0x08)
> +#define WEIM_CSxRCR2(n) (((n) * 0x18) + 0x0c)
> +#define WEIM_CSxWCR1(n) (((n) * 0x18) + 0x10)
> +#define WEIM_CSxWCR2(n) (((n) * 0x18) + 0x14)
> +#define WEIM_WCR 0x90
> +#define WEIM_WIAR 0x94
> +#define WEIM_EAR 0x98
If register set is really same as i.MX51, then probably we should
move these definitions from imx51-regs.h to imx5.h. Sascha?
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: i.MX53 - add WEIM register defines
2013-02-08 19:20 ` Alexander Shiyan
@ 2013-02-11 9:12 ` Sascha Hauer
0 siblings, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2013-02-11 9:12 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox, George Pontis
On Fri, Feb 08, 2013 at 11:20:49PM +0400, Alexander Shiyan wrote:
> > Subject: i.MX53: Add WEIM register defines ( same as i.MX51 )
> >
> > Signed-off-by: George Pontis <gpontis@spamcop.net>
> >
> > diff -Naur bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h
> > bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h
> > --- bb.a/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-04
> > 06:24:51.000000000 -0800
> > +++ bb.b/arch/arm/mach-imx/include/mach/imx53-regs.h 2013-02-06
> > 23:14:45.982747680 -0800
> > @@ -1,6 +1,17 @@
> > #ifndef __MACH_IMX53_REGS_H
> > #define __MACH_IMX53_REGS_H
> >
> > +/* WEIM registers */
> > +#define WEIM_CSxGCR1(n) (((n) * 0x18) + 0x00)
> > +#define WEIM_CSxGCR2(n) (((n) * 0x18) + 0x04)
> > +#define WEIM_CSxRCR1(n) (((n) * 0x18) + 0x08)
> > +#define WEIM_CSxRCR2(n) (((n) * 0x18) + 0x0c)
> > +#define WEIM_CSxWCR1(n) (((n) * 0x18) + 0x10)
> > +#define WEIM_CSxWCR2(n) (((n) * 0x18) + 0x14)
> > +#define WEIM_WCR 0x90
> > +#define WEIM_WIAR 0x94
> > +#define WEIM_EAR 0x98
>
> If register set is really same as i.MX51, then probably we should
> move these definitions from imx51-regs.h to imx5.h. Sascha?
Even better add a imx53_setup_weimcs() function like we have for various
other i.MXes in mach/weim.h.
(add a imx5_setup_weimcs function which has an additional base address
argument. This would then be called from
imx51_setup_weimcs/imx53_setup_weimcs).
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-11 9:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-08 19:05 i.MX53 - add WEIM register defines George Pontis
2013-02-08 19:20 ` Alexander Shiyan
2013-02-11 9:12 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox