From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH master] MAKEALL: do not early abort initial "probe" defconfig sourcing
Date: Wed, 22 Oct 2025 17:25:04 +0200 [thread overview]
Message-ID: <02d77e10-6085-4a7e-93a6-d75cfbbfa016@pengutronix.de> (raw)
In-Reply-To: <20251022150842.2222854-1-a.fatoum@pengutronix.de>
On 10/22/25 5:08 PM, Ahmad Fatoum wrote:
> The sed line recently introduced to report the shuffle seed to track down an
> issue introduced an issue of its own: It exits after getting the
> --shuffle argument. This early SIGPIPE means that the sub-make is not
> invoked and the .config is not written...
>
> Fix this by running sed until the end and just taking the first line.
That's it now hopefully. Test run on top of master is green:
https://github.com/a3f/barebox/actions
>
> Fixes: 48bdea6b4bb0 ("MAKEALL: print --shuffle seed used for initial make *_defconfig")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> MAKEALL | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAKEALL b/MAKEALL
> index b953da9cccdd..bfc0f917aca8 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -135,7 +135,7 @@ do_build_defconfig() {
> [ -n "$logdir" ] && mkdir -p "${logdir}/${defconfig}"
>
> MAKE="make -j${JOBS} ARCH=${arch} O=${BUILDDIR}"
> - shuffle=$(${MAKE} --debug=basic ${defconfig} 2>&1 | sed -n 's/.*Enabled shuffle mode: //p;T;q')
> + shuffle=$(${MAKE} --debug=basic ${defconfig} 2>&1 | sed -n 's/.*Enabled shuffle mode: //p' | head -n1)
>
> if [ -n "$shuffle" ]; then
> report "Probing ${arch} ${defconfig} (--shuffle=$shuffle)\n" >&2
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-10-22 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 15:08 Ahmad Fatoum
2025-10-22 15:25 ` Ahmad Fatoum [this message]
2025-10-22 15:55 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02d77e10-6085-4a7e-93a6-d75cfbbfa016@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox