[PATCH master] MAKEALL: do not early abort initial "probe" defconfig sourcing

[PATCH master] MAKEALL: do not early abort initial "probe" defconfig sourcing

[Ahmad Fatoum]

The sed line recently introduced to report the shuffle seed to track down an
issue introduced an issue of its own: It exits after getting the
--shuffle argument. This early SIGPIPE means that the sub-make is not
invoked and the .config is not written...

Fix this by running sed until the end and just taking the first line.

Fixes: 48bdea6b4bb0 ("MAKEALL: print --shuffle seed used for initial make *_defconfig")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 MAKEALL | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAKEALL b/MAKEALL
index b953da9cccdd..bfc0f917aca8 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -135,7 +135,7 @@ do_build_defconfig() {
 	[ -n "$logdir" ] && mkdir -p "${logdir}/${defconfig}"
 
 	MAKE="make -j${JOBS} ARCH=${arch} O=${BUILDDIR}"
-	shuffle=$(${MAKE} --debug=basic ${defconfig} 2>&1 | sed -n 's/.*Enabled shuffle mode: //p;T;q')
+	shuffle=$(${MAKE} --debug=basic ${defconfig} 2>&1 | sed -n 's/.*Enabled shuffle mode: //p' | head -n1)
 
 	if [ -n "$shuffle" ]; then
 		report "Probing ${arch} ${defconfig} (--shuffle=$shuffle)\n" >&2
-- 
2.47.3

Re: [PATCH master] MAKEALL: do not early abort initial "probe" defconfig sourcing

[Ahmad Fatoum]

On 10/22/25 5:08 PM, Ahmad Fatoum wrote:
> The sed line recently introduced to report the shuffle seed to track down an
> issue introduced an issue of its own: It exits after getting the
> --shuffle argument. This early SIGPIPE means that the sub-make is not
> invoked and the .config is not written...
> 
> Fix this by running sed until the end and just taking the first line.

That's it now hopefully. Test run on top of master is green:
https://github.com/a3f/barebox/actions

> 
> Fixes: 48bdea6b4bb0 ("MAKEALL: print --shuffle seed used for initial make *_defconfig")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  MAKEALL | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAKEALL b/MAKEALL
> index b953da9cccdd..bfc0f917aca8 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -135,7 +135,7 @@ do_build_defconfig() {
>  	[ -n "$logdir" ] && mkdir -p "${logdir}/${defconfig}"
>  
>  	MAKE="make -j${JOBS} ARCH=${arch} O=${BUILDDIR}"
> -	shuffle=$(${MAKE} --debug=basic ${defconfig} 2>&1 | sed -n 's/.*Enabled shuffle mode: //p;T;q')
> +	shuffle=$(${MAKE} --debug=basic ${defconfig} 2>&1 | sed -n 's/.*Enabled shuffle mode: //p' | head -n1)
>  
>  	if [ -n "$shuffle" ]; then
>  		report "Probing ${arch} ${defconfig} (--shuffle=$shuffle)\n" >&2

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

Re: [PATCH master] MAKEALL: do not early abort initial "probe" defconfig sourcing

[Sascha Hauer]

On Wed, 22 Oct 2025 17:08:41 +0200, Ahmad Fatoum wrote:
> The sed line recently introduced to report the shuffle seed to track down an
> issue introduced an issue of its own: It exits after getting the
> --shuffle argument. This early SIGPIPE means that the sub-make is not
> invoked and the .config is not written...
> 
> Fix this by running sed until the end and just taking the first line.
> 
> [...]

Applied, thanks!

[1/1] MAKEALL: do not early abort initial "probe" defconfig sourcing
      https://git.pengutronix.de/cgit/barebox/commit/?id=9b79d18d8d2a (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>