Re: [PATCH] fixup! test: add support for pytest --graphic

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 06.08.25 08:19, Sascha Hauer wrote:
> Supply qemu options only for qemu targets. Otherwise
> 
> labgrid-pytest --lg-env test/sandbox/sandbox_defconfig.yaml
> 
> fails with:
> 
> _pytest.outcomes.Exit: Qemu option supplied for non-Qemu targe
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks for fixing,
Ahmad

> ---
>  conftest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conftest.py b/conftest.py
> index e3f09bac31..782ebc0536 100644
> --- a/conftest.py
> +++ b/conftest.py
> @@ -125,7 +125,7 @@ def strategy(request, target, pytestconfig):
>          else:
>              pytest.exit("--graphics unsupported for target\n", 1)
>  
> -    strategy.append_qemu_args(graphics or '-nographic')
> +        strategy.append_qemu_args(graphics)
>  
>      for i, blk in enumerate(pytestconfig.option.qemu_block):
>          if virtio:


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |