From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 22 Oct 2025 14:35:12 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vBY3c-00AbhQ-2G for lore@lore.pengutronix.de; Wed, 22 Oct 2025 14:35:12 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vBY3c-0002lr-3q for lore@pengutronix.de; Wed, 22 Oct 2025 14:35:12 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rceEUjaYw2cabOFulJZiI9SNBKmD5PBAjN411CHus3Y=; b=oG744/tFIv9dTaAcUQ0u/7JHMp hvVyLQzzt9O0wduaPZsfKJrHBKY9FEkOmDpn3g4zZjgMOdsNkNRrV41jj+fgTZ/YIHsILlflsw/aq b+OFw4iFxpRt7FsxMdHab6nCk3DOqFwXH9/+p4chPuxwQZOVf0lQ7d+9S0fs/cypFV4uOjg0QJla/ lYy405fvnvXv2coF167RUHPosh6oM5HS/jwuOdhRLIdnwWPYMzo0sbQ+ayxef+S2+GMK4/0RUS4i0 Fl67FbsKTTIY6g+g/40o4uo7Tk0b6weYcbyl/idNuat5MQbjLhF414n6iOH5MF78PlpCOyxgFqaRk L8h8W2zQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBY3A-00000002oi5-0o8R; Wed, 22 Oct 2025 12:34:44 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBY38-00000002ohl-06oP for barebox@lists.infradead.org; Wed, 22 Oct 2025 12:34:43 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vBY36-0002g4-ED; Wed, 22 Oct 2025 14:34:40 +0200 Message-ID: <03e87d4d-e19a-4c98-b1b9-167b68c4ac8e@pengutronix.de> Date: Wed, 22 Oct 2025 14:34:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Jonas Rebmann , Sascha Hauer , BAREBOX References: <20251014-tlv-signature-v1-0-7a8aaf95081c@pengutronix.de> <20251014-tlv-signature-v1-12-7a8aaf95081c@pengutronix.de> <703f28ed-2d8a-4784-a850-ae577119f56e@pengutronix.de> Content-Language: en-US, de-DE, de-BE From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251022_053442_082145_AC755DEC X-CRM114-Status: GOOD ( 21.31 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 12/15] test: py: add signature to TLV integration tests X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hi, On 10/22/25 2:28 PM, Jonas Rebmann wrote: > Hi, > > On 2025-10-22 12:11, Ahmad Fatoum wrote: >> >> >> On 10/22/25 12:04 PM, Ahmad Fatoum wrote: >>> Hi, >>> >>> On 10/14/25 1:03 PM, Jonas Rebmann wrote: >>>> Add TLV signature to TLV integration tests: >>>>   - Signed TLV using development RSA key >>>>   - Modify payload and fix CRC for a "tampered" tlv >>>>   - Include both cases in generator and tlv-command tests. >>>> >>>> Use the keys selected by CRYPTO_BUILTIN_DEVELOPMENT_KEYS for all TLV >>>> testing. Consequentially add the matching private keys from the public >>>> repository at [1]. >>>> >>>> [1]: https://git.pengutronix.de/cgit/ptx-code-signing-dev/ >>>> >>>> Signed-off-by: Jonas Rebmann >>>> --- >>>>   crypto/fit-4096-development.key  |  51 ++++++++++ >>>>   crypto/fit-ecdsa-development.key |   5 + >>> >>> Move this into test/? >> >> Ah, I see the *.crt files are already in crypto... >> Can't you concatenate the *.key and *.crt files into a single pem file? >> >> That's what we do for test/self/development_rsa2048.pem and it works >> there. Removes clutter a bit. > > I'd prefer not to. I suppose our tooling supports this, users that > utilize CRYPTO_BUILTIN_DEVELOPMENT_KEYS for testing may not; and they > should not have to pick apart private and public key again. Which users? These keys are for barebox-internal consumption. > I'd consider concatenating them most of the time not the best practice. > You'll have a file of which `file` tells you it's an "OpenSSH public > key", but if you open it and then scroll down, you realize it's a > private key. > > Yes this particular private key is all but private but lets not endorse > this practice. I don't buy this argument. > Keeping them separates also makes it visible where we use the private > key: We need it when creating the signed TLVs in test/py/test_tlv.py and > only there. The private key we already have in tree are piggy backing on the public key. I think we should do the same here as well. Cheers, Ahmad > > Regards, > Jonas > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |