Re: [PATCH 3/3] driver: Call of_clk_set_defaults for each probed device

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Sascha,

On 2/13/20 11:58 AM, Sascha Hauer wrote:
> So far we only honour the assigned-clocks and assigned-clock-rates
> device tree properties for the clock controller nodes. With this patch
> we also honour the properties for each device which is done by Linux
> as well.

This breaks the default barebox console on the i.MX7 sabresd.
The default UART, uart1, specifies assigned-clock-parents, which is now applied
and causes garbage to be output on the serial port.

&uart1 {
       /delete-property/ assigned-clocks;
       /delete-property/ assigned-clock-parents;
};

Fixes it, but I didn't dig deeper than that.

> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/base/driver.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/base/driver.c b/drivers/base/driver.c
> index eec2a2d8a2..247456a2c6 100644
> --- a/drivers/base/driver.c
> +++ b/drivers/base/driver.c
> @@ -36,6 +36,7 @@
>  #include <linux/err.h>
>  #include <complete.h>
>  #include <pinctrl.h>
> +#include <linux/clk/clk-conf.h>
>  
>  LIST_HEAD(device_list);
>  EXPORT_SYMBOL(device_list);
> @@ -86,6 +87,7 @@ int device_probe(struct device_d *dev)
>  	int ret;
>  
>  	pinctrl_select_state_default(dev);
> +	of_clk_set_defaults(dev->device_node, false);
>  
>  	list_add(&dev->active, &active);
>  
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox