From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLKp1-0006Nj-Qq for barebox@lists.infradead.org; Mon, 06 Apr 2020 06:01:25 +0000 References: <20200213105803.32096-1-s.hauer@pengutronix.de> <20200213105803.32096-3-s.hauer@pengutronix.de> From: Ahmad Fatoum Message-ID: <0755ee61-3cd4-3e42-8d9c-cd57eb615ce6@pengutronix.de> Date: Mon, 6 Apr 2020 08:01:19 +0200 MIME-Version: 1.0 In-Reply-To: <20200213105803.32096-3-s.hauer@pengutronix.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/3] driver: Call of_clk_set_defaults for each probed device To: Sascha Hauer , Barebox List , Steffen Trumtrar Hello Sascha, On 2/13/20 11:58 AM, Sascha Hauer wrote: > So far we only honour the assigned-clocks and assigned-clock-rates > device tree properties for the clock controller nodes. With this patch > we also honour the properties for each device which is done by Linux > as well. This breaks the default barebox console on the i.MX7 sabresd. The default UART, uart1, specifies assigned-clock-parents, which is now applied and causes garbage to be output on the serial port. &uart1 { /delete-property/ assigned-clocks; /delete-property/ assigned-clock-parents; }; Fixes it, but I didn't dig deeper than that. > > Signed-off-by: Sascha Hauer > --- > drivers/base/driver.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/base/driver.c b/drivers/base/driver.c > index eec2a2d8a2..247456a2c6 100644 > --- a/drivers/base/driver.c > +++ b/drivers/base/driver.c > @@ -36,6 +36,7 @@ > #include > #include > #include > +#include > > LIST_HEAD(device_list); > EXPORT_SYMBOL(device_list); > @@ -86,6 +87,7 @@ int device_probe(struct device_d *dev) > int ret; > > pinctrl_select_state_default(dev); > + of_clk_set_defaults(dev->device_node, false); > > list_add(&dev->active, &active); > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox