From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 05 Apr 2024 13:47:04 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rsi2C-00CqOm-20 for lore@lore.pengutronix.de; Fri, 05 Apr 2024 13:47:04 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsi2C-0003J6-2F for lore@pengutronix.de; Fri, 05 Apr 2024 13:47:04 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HMTVdFEoeNBVrLmeElRh4kJw1WnqYjFm5R94Dc4Tez4=; b=braqu/n5Q5yH+yY9CGKHE4sxyO +u+1f9Q/995Z4SLmcLQeUMgOY6ZIgu0q0RRS7kPr5WumM6mIACYmLMBLU/R5/9Um/KT2zcoRAiLNs TlCAQVqy9yjxJroZdDPPRdLgcQdHAu7lPSoqCjjQeeAsWRjdpGBsksSnKsEy7f9ogjqFfi2rxkb01 R+4mr8M9Ugku/MGzhnSXKhAGMyPgS2XwVs+1m8WvVOw8H8xL3KYW7KalMjKU9UGbIJ9QzrCfPxsSt 7bRXsZsuMa0p3rIx720BYQGQ3EZpF6aum5S6EUlOupBmBpIezUdP9cQpJWryTCEy7n/OtHkDyE/85 wDDpjYLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsi1g-00000006jt3-0Grq; Fri, 05 Apr 2024 11:46:32 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsi1d-00000006jre-0Yxp for barebox@lists.infradead.org; Fri, 05 Apr 2024 11:46:30 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rsi1a-0002jC-ME; Fri, 05 Apr 2024 13:46:26 +0200 Message-ID: <09357d76-9bce-4087-ac93-4f4b4cf3c5f1@pengutronix.de> Date: Fri, 5 Apr 2024 13:46:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sascha Hauer , Barebox List References: <20240405101250.2523616-1-s.hauer@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20240405101250.2523616-1-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_044629_207323_E86F19D3 X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] arm: mecsbc: fixup /regulator-sd device tree node X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello Sascha, On 05.04.24 12:12, Sascha Hauer wrote: > The MECSBC prototype board has a bug which makes the 1.8V SD mode > unusable. Add a fixup which sets the regulator-min-microvolt property of > the SD regulator to 3.3V to prevent the Kernel from going into 1.8V. Isn't that what the MMC no-1-8-v device tree property is for? Cheers, Ahmad > > Signed-off-by: Sascha Hauer > --- > arch/arm/boards/protonic-mecsbc/board.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm/boards/protonic-mecsbc/board.c b/arch/arm/boards/protonic-mecsbc/board.c > index 3ba8fb8d1c..56f7ca393a 100644 > --- a/arch/arm/boards/protonic-mecsbc/board.c > +++ b/arch/arm/boards/protonic-mecsbc/board.c > @@ -90,6 +90,24 @@ static void mecsbc_process_adc(struct device *dev) > pr_info("VIN = %d V\n", mecsbc_get_vin_mv() / 1000); > } > > +static int mecsbc_sd_of_fixup(struct device_node *root, void *context) > +{ > + struct device *dev = context; > + struct device_node *np; > + > + dev_info(dev, "Fixing up /regulator-sd\n"); > + > + np = of_find_node_by_path_from(root, "/regulator-sd"); > + if (!np) { > + dev_err(dev, "Cannot find /regulator-sd node\n"); > + return 0; > + } > + > + of_property_write_u32(np, "regulator-min-microvolt", 3300000); > + > + return 0; > +} > + > static int mecsbc_of_fixup_hwrev(struct device *dev) > { > const char *compat; > @@ -103,6 +121,9 @@ static int mecsbc_of_fixup_hwrev(struct device *dev) > > free(buf); > > + if (mecsbc_data.hw_id == 0 && mecsbc_data.hw_rev == 0) > + of_register_fixup(mecsbc_sd_of_fixup, dev); > + > return 0; > } > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |