From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] tftp: allocate at least 4096 bytes for FIFO
Date: Mon, 5 Sep 2022 14:07:31 +0200 [thread overview]
Message-ID: <0b0bc5d9-90d7-0fd0-906e-e3a7a893b33b@pengutronix.de> (raw)
In-Reply-To: <ly1qsq2nxy.fsf@ensc-pc.intern.sigma-chemnitz.de>
Hello Enrico,
On 05.09.22 11:03, Enrico Scholz wrote:
> Ahmad Fatoum <a.fatoum@pengutronix.de> writes:
>
>> On one board, boots from /mnt/tftp currently fail for me with:
>>
>> ERROR: tftp: tftp: not enough room in kfifo (only 1376 out of 1432 written
>
> Thanks for noticing that; I sent fixups for the recent patchset.
Thanks for the prompt reply and series.
> Perhaps, can you test it on your failing platform with changing
>
> | #define TFTP_EXTRA_BLOCKS 2
>
> to
>
> | #define TFTP_EXTRA_BLOCKS 0
>
> ?
>
> This should turn off the workaround of over-allocating memory and isolate
> (and verify) the fix for the real problem.
Issue was not reproducible with TFTP_EXTRA_BLOCKS 0.
FWIW, the same barebox binary only had the issue when booting via USB network adapter
(DUB-E100) on one board, but not when booting from i.MX8MM FEC on another board.
Cheers,
Ahmad
>
>
>
> Enrico
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2022-09-05 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 7:00 Ahmad Fatoum
2022-09-05 9:03 ` Enrico Scholz
2022-09-05 12:07 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b0bc5d9-90d7-0fd0-906e-e3a7a893b33b@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=enrico.scholz@sigma-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox