From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 11/13] common: cdev-alias: rename struct
Date: Mon, 15 Dec 2025 12:27:02 +0100 [thread overview]
Message-ID: <0c0c3c97-b465-45f8-a59a-032f19aec882@pengutronix.de> (raw)
In-Reply-To: <20251209-devfs-v2-11-62ae16698cff@pengutronix.de>
On 12/9/25 1:51 PM, Sascha Hauer wrote:
> We'll introduce a globally available struct cdev_alias in the next step,
> so rename struct cdev_alias in common/cdev-alias.c to avoid name
> conflicts.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> common/cdev-alias.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/common/cdev-alias.c b/common/cdev-alias.c
> index 329ba9e97c16fe7a90d09c0bb31ef3359b72b5d0..e5a059ad7f4d9bc447c44072c5c7744051d12a0e 100644
> --- a/common/cdev-alias.c
> +++ b/common/cdev-alias.c
> @@ -11,13 +11,13 @@
> #include <driver.h>
> #include <init.h>
>
> -struct cdev_alias {
> +struct cdev_alias_res {
> const char *name;
> - int (*resolve)(struct cdev_alias *, const char *arg,
> + int (*resolve)(struct cdev_alias_res *, const char *arg,
> cdev_alias_processor_t fn, void *data);
> };
>
> -static int cdev_alias_resolve_bootsource(struct cdev_alias *cdev_alias,
> +static int cdev_alias_resolve_bootsource(struct cdev_alias_res *cdev_alias_res,
> const char *partname,
> cdev_alias_processor_t fn,
> void *data)
> @@ -37,7 +37,7 @@ static int cdev_alias_resolve_bootsource(struct cdev_alias *cdev_alias,
> return fn(cdev, data);
> }
>
> -static int cdev_alias_resolve_diskuuid(struct cdev_alias *cdev_alias,
> +static int cdev_alias_resolve_diskuuid(struct cdev_alias_res *cdev_alias_res,
> const char *uuid,
> cdev_alias_processor_t fn,
> void *data)
> @@ -67,7 +67,7 @@ static int cdev_alias_resolve_diskuuid(struct cdev_alias *cdev_alias,
> return 0;
> }
>
> -static struct cdev_alias cdev_alias_aliases[] = {
> +static struct cdev_alias_res cdev_alias_aliases[] = {
> { "bootsource", cdev_alias_resolve_bootsource },
> { "diskuuid", cdev_alias_resolve_diskuuid },
> { /* sentinel */}
> @@ -76,7 +76,7 @@ static struct cdev_alias cdev_alias_aliases[] = {
> int cdev_alias_resolve_for_each(const char *name,
> cdev_alias_processor_t fn, void *data)
> {
> - struct cdev_alias *alias;
> + struct cdev_alias_res *alias;
> int ret = 0;
> char *buf, *arg;
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-12-15 11:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 12:51 [PATCH v2 00/13] fs: Use device special nodes for devfs Sascha Hauer
2025-12-09 12:51 ` [PATCH v2 01/13] fs: devfs-core: add devfs_create_link_node() Sascha Hauer
2025-12-15 11:14 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 02/13] storage-by-alias: drop fake cdev Sascha Hauer
2025-12-15 11:15 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 03/13] fs: implement mknod Sascha Hauer
2025-12-15 11:19 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 04/13] commands: add mknod command Sascha Hauer
2025-12-15 11:21 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 05/13] fs: ramfs: add device file support Sascha Hauer
2025-12-15 11:22 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 06/13] cdev: add cdev_size() helper Sascha Hauer
2025-12-15 11:22 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 07/13] fs: fix st_size for device files Sascha Hauer
2025-12-15 11:24 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 08/13] fs: retire devfs as filesystem Sascha Hauer
2025-12-15 11:25 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 09/13] fs: include cdevname in struct stat Sascha Hauer
2025-12-15 11:25 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 10/13] fs: stat_print: get cdevname from stat Sascha Hauer
2025-12-15 11:26 ` Ahmad Fatoum
2025-12-09 12:51 ` [PATCH v2 11/13] common: cdev-alias: rename struct Sascha Hauer
2025-12-15 11:27 ` Ahmad Fatoum [this message]
2025-12-09 12:51 ` [PATCH v2 12/13] fs: replace cdev links with aliases Sascha Hauer
2025-12-15 11:31 ` Ahmad Fatoum
2025-12-15 12:17 ` Sascha Hauer
2025-12-09 12:51 ` [PATCH v2 13/13] ls: use ~0 for FILE_SIZE_STREAM Sascha Hauer
2025-12-15 11:32 ` Ahmad Fatoum
2025-12-15 12:16 ` [PATCH v2 00/13] fs: Use device special nodes for devfs Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c0c3c97-b465-45f8-a59a-032f19aec882@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox