mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 4/8] initcall: add of_populate_initcall
Date: Tue, 20 Oct 2020 18:50:38 +0200	[thread overview]
Message-ID: <0ebc5b33-11c4-ab3c-8e6c-ba86c8f6cfb6@pengutronix.de> (raw)
In-Reply-To: <20201020161853.myiu3wtlc6dod6g4@pengutronix.de>

Hi,

On 10/20/20 6:18 PM, Marco Felsch wrote:
> Hi Ahmad,
> 
> On 20-10-02 07:53, Ahmad Fatoum wrote:
>>
>>
>> On 9/30/20 10:47 AM, Marco Felsch wrote:
> 
> ...
> 
>>> @@ -61,9 +64,10 @@ typedef void (*exitcall_t)(void);
>>>  #define fs_initcall(fn)			__define_initcall("9",fn,9)
>>>  #define device_initcall(fn)		__define_initcall("10",fn,10)
>>>  #define crypto_initcall(fn)		__define_initcall("11",fn,11)
>>> -#define late_initcall(fn)		__define_initcall("12",fn,12)
>>> -#define environment_initcall(fn)	__define_initcall("13",fn,13)
>>> -#define postenvironment_initcall(fn)	__define_initcall("14",fn,14)
>>> +#define of_populate_initcall(fn)	__define_initcall("12",fn,15)
>>
>> s/15/12/ ? (Likewise below)
> 
> I would like to keep it before late_initcall() due to the impact of that
> initcall and following environment_initcall(). At least the
> environment_initcall() assumes that devices are available to setup the
> /env correctly. Therefore I added it before late_initcall(). I can give
> it a try to move it behind the late_inicall if you want.

Case in point! s/15/12/ doesn't change the initcall order, it only ensures
that you don't expand to __initcall_##fn##15 __section(.initcall.12) which
is confusing. Apparently it confused you to think I mean changing the
actual init level too :-)

> 
> Regards,
>   Marco
> 
>>> +#define late_initcall(fn)		__define_initcall("13",fn,12)
>>> +#define environment_initcall(fn)	__define_initcall("14",fn,13)
>>> +#define postenvironment_initcall(fn)	__define_initcall("15",fn,14)
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-10-20 16:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  8:47 [PATCH v2 0/8] Barebox Deep-Probe Marco Felsch
2020-09-30  8:47 ` [PATCH v2 1/8] of: platform: Keep track of populated platform devices Marco Felsch
2020-10-02  5:15   ` Sascha Hauer
2020-10-02  5:47     ` Marco Felsch
2020-09-30  8:47 ` [PATCH v2 2/8] of: base: move memory init from DT to initcall Marco Felsch
2020-09-30  8:47 ` [PATCH v2 3/8] of: base: move clock init from of_probe() to barebox_register_of() Marco Felsch
2020-09-30  8:47 ` [PATCH v2 4/8] initcall: add of_populate_initcall Marco Felsch
2020-10-02  5:53   ` Ahmad Fatoum
2020-10-20 16:18     ` Marco Felsch
2020-10-20 16:50       ` Ahmad Fatoum [this message]
2020-10-20 20:08         ` Marco Felsch
2020-09-30  8:47 ` [PATCH v2 5/8] common: add initial barebox deep-probe support Marco Felsch
2020-10-01 10:13   ` Marco Felsch
2020-10-02  6:10   ` Ahmad Fatoum
2020-10-02  6:11     ` Ahmad Fatoum
2020-10-02  7:09     ` Marco Felsch
2020-10-02  7:18       ` Ahmad Fatoum
2020-09-30  8:47 ` [PATCH v2 6/8] ARM: i.MX: esdctl: add " Marco Felsch
2020-09-30  8:47 ` [PATCH v2 7/8] ARM: stm32mp: ddrctrl: " Marco Felsch
2020-09-30  8:47 ` [PATCH v2 8/8] ARM: boards: mx6-sabrelite: " Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ebc5b33-11c4-ab3c-8e6c-ba86c8f6cfb6@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox