From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT40H-0002Rs-T6 for barebox@lists.infradead.org; Thu, 15 Oct 2020 14:13:15 +0000 References: <20201015132048.420995-1-m.tretter@pengutronix.de> <20201015132048.420995-3-m.tretter@pengutronix.de> <42b7d165-9bc6-cbc6-57f7-9e537906e3df@pengutronix.de> <20201015140420.GA18981@pengutronix.de> From: Ahmad Fatoum Message-ID: <0ecaf0ca-f87e-be20-976d-7e4263ea792a@pengutronix.de> Date: Thu, 15 Oct 2020 16:13:12 +0200 MIME-Version: 1.0 In-Reply-To: <20201015140420.GA18981@pengutronix.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/3] net: macb: fix compiler warning for 64 bit systems To: Michael Tretter Cc: barebox@lists.infradead.org Hi, On 10/15/20 4:04 PM, Michael Tretter wrote: > On Thu, 15 Oct 2020 15:29:01 +0200, Ahmad Fatoum wrote: >> On 10/15/20 3:20 PM, Michael Tretter wrote: >>> On arm64 the compiler prints the following warning, when the macb driver >>> is enabled: >>> >>> warning: cast from pointer to integer of different size >>> >>> Add the same explicit cast as implemented for all other dma addresses in >>> the macb driver. >>> >>> Fixes: befd110b5922 ("net: macb: init multiple dummy TX queues") >> >> I don't think this qualifies as a fix. You just silence the compiler >> warning you that your truncate the upper 32 bits of your buffer's >> address. This works because your SDRAM's location in physical memory >> is below 4G. > > Correct. Which is exactly the same as assumed by the entire driver... Ye, I am commenting on your Fixes: line though :-) > > Michael > >> >>> Signed-off-by: Michael Tretter >>> --- >>> drivers/net/macb.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/macb.c b/drivers/net/macb.c >>> index fa530cfe8e4c..188dbf2d8c15 100644 >>> --- a/drivers/net/macb.c >>> +++ b/drivers/net/macb.c >>> @@ -365,7 +365,7 @@ static int gmac_init_dummy_tx_queues(struct macb_device *macb) >>> MACB_BIT(TX_LAST) | MACB_BIT(TX_USED); >>> >>> for (i = 1; i < num_queues; i++) >>> - gem_writel_queue_TBQP(macb, &macb->gem_q1_descs[0], i - 1); >>> + gem_writel_queue_TBQP(macb, (ulong)macb->gem_q1_descs, i - 1); >>> >>> return 0; >>> } >>> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox