Re: [PATCH 0/5] Filesystem memory corruption fixes

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 27.02.25 10:36, Sascha Hauer wrote:
> On Sat, Feb 22, 2025 at 12:46:18PM -0800, Jonathan Bar Or wrote:
>> Those are awesome, thank you.
>> We intend to publicly disclose March 19th, is that okay?
> 
> Well, this is a public list, so they are already disclosed...

In a way, yes, but most users will probably only find out about this
once their CVE tooling reports that they are using a barebox version
that doesn't fix e.g. CVE-2025-26722.

CVE-2025-26722 (and I assume the others) are reserved right now, but
lack a description of the issue and its possible security implications.

We should probably write down some extra policy here:

  - Should CVE numbers even be mentioned for yet-undisclosed issues?

  - An explicit policy about disclosure timeline. Bugs are fixed all the
    time and I think, it's desirable that disclosure is postponed until
    after a release, so users informed of the issue directly know
    what to do about it. For critical security issues, a point release
    can be done on short notice

@Jonathan, March 19th is ok for us, but we don't object to any earlier
date.

Cheers,
Ahmad

> Sascha
> 
>>
>> Jonathan
>>
>> On Thu, Feb 20, 2025 at 11:33 PM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>>>
>>>
>>> On Wed, 19 Feb 2025 15:18:39 +0100, Sascha Hauer wrote:
>>>> These are some fixes for memory corruptions that can occur on corrupted
>>>> or manipulated filesystems.
>>>>
>>>> In case you use one of the affected filesystems in a secure boot chain
>>>> you should apply these patches.
>>>>
>>>> Normally you shouldn't use a barebox filesystem in a secure boot chain,
>>>> but instead use FIT images on a raw partition. We never made this explicit
>>>> though. Ahmad has done this recently:
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>> [1/5] CVE-2025-26722: fs: squashfs: Ensure positive inode length
>>>       https://git.pengutronix.de/cgit/barebox/commit/?id=6281a871e2c6 (link may not be stable)
>>> [2/5] CVE-2025-26724: fs: cramfs: fix malloc(size + constant) buffer overflow issues
>>>       https://git.pengutronix.de/cgit/barebox/commit/?id=f86e528c8fba (link may not be stable)
>>> [3/5] CVE-2025-26723: fs: ext4: fix malloc(size + constant) buffer overflow issues
>>>       https://git.pengutronix.de/cgit/barebox/commit/?id=51eea5c16fd2 (link may not be stable)
>>> [4/5] CVE-2025-26725: fs: jffs2: fix malloc(size + constant) buffer overflow issues
>>>       https://git.pengutronix.de/cgit/barebox/commit/?id=e7397340359d (link may not be stable)
>>> [5/5] CVE-2025-26721: fs: pstore: fix malloc(size + constant) buffer overflow issues
>>>       https://git.pengutronix.de/cgit/barebox/commit/?id=7563f5722dfd (link may not be stable)
>>>
>>> Best regards,
>>> --
>>> Sascha Hauer <s.hauer@pengutronix.de>
>>>
>>
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |