From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] boot: fix systemd watchdog command line argument
Date: Thu, 20 Feb 2025 13:06:53 +0100 [thread overview]
Message-ID: <1058511f-b54e-44be-b267-dce2b1fd048a@pengutronix.de> (raw)
In-Reply-To: <20250220091743.3489127-1-s.hauer@pengutronix.de>
On 20.02.25 10:17, Sascha Hauer wrote:
> The kernel command line option to specify the watchdog to use is
> "systemd.watchdog_device" as specified in [1], not
> "systemd.watchdog-device"
>
> [1] https://www.freedesktop.org/software/systemd/man/latest/kernel-command-line.html#systemd.watchdog_sec=
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Please also include the typo fix in the common/Kconfig help text for
CONFIG_SYSTEMD_OF_WATCHDOG.
With that squashed:
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
I could swear I have tested this with two watchdogs back then...
Anyways, I have submitted a fix to the systemd documentation here:
https://github.com/systemd/systemd/pull/36453
Thanks,
Ahmad
> ---
> common/oftree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/oftree.c b/common/oftree.c
> index 4afe955719..2ebde791c7 100644
> --- a/common/oftree.c
> +++ b/common/oftree.c
> @@ -172,7 +172,7 @@ static void watchdog_build_bootargs(struct watchdog *watchdog, struct device_nod
> if (alias_id < 0)
> return;
>
> - buf = basprintf("systemd.watchdog-device=/dev/watchdog%d", alias_id);
> + buf = basprintf("systemd.watchdog_device=/dev/watchdog%d", alias_id);
> if (!buf)
> return;
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-02-20 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 9:17 Sascha Hauer
2025-02-20 12:06 ` Ahmad Fatoum [this message]
2025-02-20 17:45 ` Ahmad Fatoum
2025-02-21 13:20 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1058511f-b54e-44be-b267-dce2b1fd048a@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox