From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx009.vodafonemail.xion.oxcs.net ([153.92.174.39]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFH3z-0004jh-UA for barebox@lists.infradead.org; Fri, 20 Mar 2020 12:47:49 +0000 Received: from vsmx002.vodafonemail.xion.oxcs.net (unknown [192.168.75.192]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTP id 37AA660575A for ; Fri, 20 Mar 2020 12:47:33 +0000 (UTC) Received: from app-46.app.xion.oxcs.net (app-46.app.xion.oxcs.net [10.10.1.46]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 1D9F260531F for ; Fri, 20 Mar 2020 12:47:30 +0000 (UTC) Date: Fri, 20 Mar 2020 13:47:27 +0100 (CET) From: Giorgio Dal Molin Message-ID: <1083579.30874.1584708448026@mail.vodafone.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: suspicious header files diff To: barebox@lists.infradead.org Hi, I'm getting a compile error while building barebox for an imx7d after configuring in CONFIG_RESET_IMX7: ... CHK include/generated/compile.h CC drivers/reset/reset-imx7.o /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:181:3: error: 'IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N' undeclared here (not in a function); did you mean 'IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N'? 181 | [IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:181:3: error: array index in initializer not of integer type /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:181:3: note: (near initialization for 'imx8mq_src_signals') /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:182:3: error: 'IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N' undeclared here (not in a function); did you mean 'IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N'? 182 | [IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:182:3: error: array index in initializer not of integer type /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:182:3: note: (near initialization for 'imx8mq_src_signals') /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:183:3: error: 'IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N' undeclared here (not in a function); did you mean 'IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N'? 183 | [IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:183:3: error: array index in initializer not of integer type /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:183:3: note: (near initialization for 'imx8mq_src_signals') make[3]: *** [/home/giorgio/projects/wpt_barebox/scripts/Makefile.build:215: drivers/reset/reset-imx7.o] Error 1 make[2]: *** [/home/giorgio/projects/wpt_barebox/scripts/Makefile.build:367: drivers/reset] Error 2 make[1]: *** [/home/giorgio/projects/wpt_barebox/Makefile:804: drivers] Error 2 make: *** [Makefile:118: sub-make] Error 2 After a bit of search I've found the following two nearly identical headers: -1- include/dt-bindings/reset/imx8mq-reset.h -2- dts/include/dt-bindings/reset/imx8mq-reset.h maybe there is a typo (DSI <=> DIS): #define IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N 23 #define IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N 24 #define IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N 25 #define IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N 23 #define IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N 24 #define IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N 25 giorgio _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox