mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jan Weitzel <J.Weitzel@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] hush: Fix return code when calling 'exit' inside loops
Date: Fri, 26 Mar 2010 15:54:43 +0100	[thread overview]
Message-ID: <1269615283.10401.0.camel@lws-weitzel> (raw)
In-Reply-To: <20100324113526.GV2241@pengutronix.de>

works fine

Am Mittwoch, den 24.03.2010, 12:35 +0100 schrieb Sascha Hauer:
> v2: Do not exit from all scripts but only the current one
> 
> This fixes the case:
> 
> barebox:/ cat /test
> if [ 0 = 0 ]; then
> 	exit 1
> fi
> barebox:/ /test
> barebox:/ echo $?
> 0
> barebox:/
> 
> Also, remove code to not allow exit from main shell. The for(;;) loop
> in common/startup.c will bring us back anyway.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  common/hush.c |   14 +++-----------
>  1 files changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/common/hush.c b/common/hush.c
> index cf6704b..6a8b56b 100644
> --- a/common/hush.c
> +++ b/common/hush.c
> @@ -699,7 +699,7 @@ static int run_list_real(struct pipe *pi)
>  		debug("run_pipe_real returned %d\n",rcode);
>  		if (rcode < -1) {
>  			last_return_code = -rcode - 2;
> -			return -2;	/* exit */
> +			return rcode;	/* exit */
>  		}
>  		last_return_code=rcode;
>  		if ( rmode == RES_IF || rmode == RES_ELIF )
> @@ -1371,17 +1371,9 @@ static int parse_stream_outer(struct p_context *ctx, struct in_str *inp, int fla
>  				free_pipe_list(ctx->list_head, 0);
>  				continue;
>  			}
> -			if (code == -2) {	/* exit */
> +			if (code < -1) {	/* exit */
>  				b_free(&temp);
> -
> -				/* XXX hackish way to not allow exit from main loop */
> -				if (inp->peek == file_peek) {
> -					printf("exit not allowed from main input shell.\n");
> -					code = 0;
> -					continue;
> -				}
> -				code = last_return_code;
> -				break;
> +				return -code - 2;
>  			}
>  		} else {
>  			if (ctx->old_flag != 0) {
> -- 
> 1.7.0
> 



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2010-03-26 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24  7:25 Sascha Hauer
2010-03-24 11:35 ` Sascha Hauer
2010-03-26 14:54   ` Jan Weitzel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269615283.10401.0.camel@lws-weitzel \
    --to=j.weitzel@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox