From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: barebox@lists.infradead.org
Subject: [PATCH 5/9 V2] vsprintf: add %w and %w support to print unit
Date: Thu, 2 Sep 2010 21:41:46 +0200 [thread overview]
Message-ID: <1283456510-28086-5-git-send-email-plagnioj@jcrosoft.com> (raw)
In-Reply-To: <20100902194046.GA21449@game.jcrosoft.org>
Show a '%w' or %W thing. This will show a unit
at format xxx[.xxx][ ][ kMG] with iEEE 1541 support
The precision can not excess the base kMG of the current unit
otherwise it will be automatically reduce
If no precision is specified and there is rest we will use a default
precision of 3 as 66.667 M or 66.667M
%#w or %#W will add a space between the value and the unit
The base will be typically 1000 for Hz or B and 1024 for iB
for 1024 the i is automactically add for val >= 1024
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
include/linux/kernel.h | 20 ++++++++++
lib/vsprintf.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 111 insertions(+), 0 deletions(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index e9e2f07..b605946 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -5,6 +5,26 @@
#include <linux/barebox-wrapper.h>
/*
+ * This looks more complex than it should be. But we need to
+ * get the type for the ~ right in round_down (it needs to be
+ * as wide as the result!), and we want to evaluate the macro
+ * arguments just once each.
+ */
+#define __round_mask(x, y) ((__typeof__(x))((y)-1))
+#define round_up(x, y) ((((x)-1) | __round_mask(x, y))+1)
+#define round_down(x, y) ((x) & ~__round_mask(x, y))
+
+#define FIELD_SIZEOF(t, f) (sizeof(((t*)0)->f))
+#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d))
+#define roundup(x, y) ((((x) + ((y) - 1)) / (y)) * (y))
+#define DIV_ROUND_CLOSEST(x, divisor)( \
+{ \
+ typeof(divisor) __divisor = divisor; \
+ (((x) + ((__divisor) / 2)) / (__divisor)); \
+} \
+)
+
+/*
* min()/max()/clamp() macros that also do
* strict type-checking.. See the
* "unnecessary" pointer comparison.
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 6066845..18ba371 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -254,6 +254,88 @@ static char *symbol_string(char *buf, char *end, void *ptr, int field_width, int
}
/*
+ * Show a '%w' or %W thing. This will show a unit
+ * at format xxx[.xxx][ ][ kMG] with iEEE 1541 support
+ *
+ * The precision can not excess the base kMG of the current unit
+ * otherwise it will be automatically reduce
+ *
+ * If no precision is specified and there is rest we will use a default
+ * precision of 3 as 66.667 M or 66.667M
+ *
+ * %#w or %#W will add a space between the value and the unit
+ *
+ * The base will be typically 1000 for Hz or B and 1024 for iB
+ * for 1024 the i is automactically add for val >= 1024
+ */
+static char *unit_string(char *buf, char *end, long val, int base, int field_width, int precision, int flags)
+{
+ long rest = 0;
+ long integer;
+ long pr = 3;
+ long pr_mul = 1;
+ long unit = 1;
+ char format[] = " kMG";
+ int pow, i;
+
+ for (pow = 0; pow < strlen(format) - 1; pow++) {
+ if (val < unit * base)
+ break;
+ unit *= base;
+ }
+
+ integer = val / unit;
+
+ if (precision != -1) {
+ if (precision > pow * 3)
+ precision = pow * 3;
+ pr = precision;
+ }
+
+ for (i = 0; i < pr; i++) {
+ pr_mul *= 10;
+ }
+
+ if (val % unit) {
+ rest = DIV_ROUND_CLOSEST(pr_mul * (val - (integer * unit)), unit);
+
+ if (rest >= pr_mul) {
+ rest -= pr_mul;
+ integer++;
+ }
+ }
+
+ buf = number(buf, end, integer, 10, field_width, -1, flags & ~LEFT);
+
+ if (rest != 0 || precision != -1) {
+ if (buf < end)
+ *buf = '.';
+ buf++;
+ buf = number(buf, end, rest, 10, -1, pr, flags | ZEROPAD);
+ }
+
+ /* use SPECIAL as SPACE could be used for the interger part */
+ if (flags & SPECIAL) {
+ if (buf < end)
+ *buf = ' ';
+ buf++;
+ }
+
+ if (pow > 0) {
+ if (buf < end)
+ *buf = format[pow];
+ buf++;
+ if (base == 1024) {
+ if (buf < end)
+ *buf = 'i';
+ buf++;
+ }
+ }
+
+ return buf;
+}
+
+/*
* Show a '%p' thing. A kernel extension is that the '%p' is followed
* by an extra set of alphanumeric characters that are extended format
* specifiers.
@@ -291,6 +373,7 @@ static char *pointer(const char *fmt, char *buf, char *end, void *ptr, int field
* %pS output the name of a text symbol
* %pF output the name of a function pointer
* %pR output the address range in a struct resource
+ * %W and %w output at unit format with iEEE 1541 support
*
* The return value is the number of characters which would
* be generated for the given input, excluding the trailing
@@ -421,6 +504,14 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
str = string(str, end, va_arg(args, char *), field_width, precision, flags);
continue;
+ case 'W':
+ str = unit_string(str, end, va_arg(args, long), 1024, field_width, precision, flags);
+ continue;
+
+ case 'w':
+ str = unit_string(str, end, va_arg(args, long), 1000, field_width, precision, flags);
+ continue;
+
case 'p':
str = pointer(fmt+1, str, end,
va_arg(args, void *),
--
1.7.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-09-02 19:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 14:10 [PATCH 0/9] preperation for sh adding Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 14:10 ` [PATCH 1/9] types.h: move __kernel_dev_t to include/linux/types.h Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 14:10 ` [PATCH 2/9] device: fix dev_name Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 14:10 ` [PATCH 3/9] stm8815: fix the uart device clock match Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 14:10 ` [PATCH 4/9] arm: move clkdev to drivers/clk Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 14:10 ` [PATCH 5/9] vsprintf: add %w and %w support to print unit Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 15:29 ` Uwe Kleine-König
2010-09-02 15:32 ` Uwe Kleine-König
[not found] ` <20100902155421.GB28968@game.jcrosoft.org>
2010-09-02 17:54 ` Uwe Kleine-König
2010-09-02 14:10 ` [PATCH 6/9] at91/clock: switch to %w for clock info printing Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 14:10 ` [PATCH 7/9] cfi_flash: use %W and IEEE 1541 format Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 14:10 ` [PATCH 8/9] use %W instead of size_human_readable and use " Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 14:10 ` [PATCH 9/9] clkdev: add print clk info command Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 15:22 ` Uwe Kleine-König
2010-09-02 19:40 ` [PATCH 0/9 V2] preperation for sh adding Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 19:41 ` [PATCH 1/9 V2] types.h: move __kernel_dev_t to include/linux/types.h Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 19:41 ` [PATCH 2/9 V2] device: fix dev_name Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 19:41 ` [PATCH 3/9 V2] stm8815: fix the uart device clock match Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 19:41 ` [PATCH 4/9 V2] arm: move clkdev to drivers/clk Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 19:41 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2010-09-03 18:34 ` [PATCH 5/9 V2] vsprintf: add %w and %w support to print unit Uwe Kleine-König
2010-09-02 19:41 ` [PATCH 6/9 V2] at91/clock: switch to %w for clock info printing Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 19:41 ` [PATCH 7/9 V2] cfi_flash: use %W and IEEE 1541 format Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 19:41 ` [PATCH 8/9 V2] use %W instead of size_human_readable and use " Jean-Christophe PLAGNIOL-VILLARD
2010-09-02 19:41 ` [PATCH 9/9 V2] clkdev: add print clk info command Jean-Christophe PLAGNIOL-VILLARD
2010-09-16 10:38 ` [PATCH 0/9 V2] preperation for sh adding Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283456510-28086-5-git-send-email-plagnioj@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox