From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 31.mail-out.ovh.net ([213.186.62.10]) by bombadil.infradead.org with smtp (Exim 4.72 #1 (Red Hat Linux)) id 1OsdWC-0007vu-7j for barebox@lists.infradead.org; Mon, 06 Sep 2010 15:22:05 +0000 From: Jean-Christophe PLAGNIOL-VILLARD Date: Mon, 6 Sep 2010 17:21:14 +0200 Message-Id: <1283786474-24332-1-git-send-email-plagnioj@jcrosoft.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH V2] Menu: add box style entry To: barebox@lists.infradead.org this will allow you to create a box style entry via C API by specifying the type as struct menu_entry me = { .display "test", .type = MENU_ENTRY_BOX, .box_state = 1, .action = action_to_run, } and via shell menu -e -a -m -c [-R] [-b 0|1] -d menu -e -a -m -u submenu -d [-b 0|1] -b with 0 for not selected and 1 for selected and -c for the command to run when changing state Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD --- V2: fix commit message remove the box_command as we do not need it as we can do one acion only for box type, it selection action except for sub menu which as hanlde via C API already this is apply after the auto select patch The following changes since commit 0d35c3c8a0c2a1f1ff06eac20a12af0186753bc4: menu: simplify usage for clients (2010-08-30 21:06:02 +0200) are available in the git repository at: git://git.jcrosoft.org/barebox.git menu Jean-Christophe PLAGNIOL-VILLARD (3): menu: shell fix do_menu_select menu: add auto select support Menu: add box style entry commands/menu.c | 55 +++++++++++++++++++++++++----- common/menu.c | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++---- include/menu.h | 18 +++++++++- 3 files changed, 154 insertions(+), 18 deletions(-) Best Regards, J. commands/menu.c | 30 +++++++++++++++++++++++------- common/menu.c | 44 ++++++++++++++++++++++++++++++++++++++------ include/menu.h | 14 +++++++++++++- 3 files changed, 74 insertions(+), 14 deletions(-) diff --git a/commands/menu.c b/commands/menu.c index 2c9ddc3..b0fdd99 100644 --- a/commands/menu.c +++ b/commands/menu.c @@ -49,11 +49,13 @@ struct cmd_menu { char *submenu; int num; int auto_select; + menu_entry_type type; + int box_state; #endif }; #if defined(CONFIG_CMD_MENU_MANAGEMENT) -#define OPTS "m:earlc:d:RsSn:u:A:" +#define OPTS "m:earlc:d:RsSn:u:A:b:B:" #define is_entry(x) ((x)->entry) #else #define OPTS "m:ls" @@ -62,8 +64,8 @@ struct cmd_menu { #if defined(CONFIG_CMD_MENU_MANAGEMENT) /* - * menu -e -a -m -c [-R] -d - * menu -e -a -m -u submenu -d + * menu -e -a -m -c [-R] [-b 0|1 ] -d + * menu -e -a -m -u submenu -d [-b 0|1] */ static int do_menu_entry_add(struct cmd_menu *cm) { @@ -83,11 +85,15 @@ static int do_menu_entry_add(struct cmd_menu *cm) if (cm->submenu) me = menu_add_submenu(m, cm->submenu, cm->description); else - me = menu_add_command_entry(m, cm->description, cm->command); + me = menu_add_command_entry(m, cm->description, cm->command, + cm->type); if (!me) return PTR_ERR(me); - me->non_re_ent = !cm->re_entrant; + me->box_state = cm->box_state > 0 ? 1 : 0; + + if (!cm->submenu) + me->non_re_ent = !cm->re_entrant; return 0; } @@ -359,6 +365,12 @@ static int do_menu(struct command *cmdtp, int argc, char *argv[]) break; case 'A': cm.auto_select = simple_strtoul(optarg, NULL, 10); + case 'b': + cm.type = MENU_ENTRY_BOX; + cm.box_state = simple_strtoul(optarg, NULL, 10); + break; + case 'B': + cm.command = optarg; break; #endif default: @@ -431,11 +443,15 @@ static const __maybe_unused char cmd_menu_help[] = "\n" "Add an entry\n" " (-R for do no exit the menu after executing the command)\n" -" menu -e -a -m -c [-R] -d \n" +" (-b for box style 1 for selected)\n" +" (and optional -c for the command to run when we change the state)\n" +" menu -e -a -m -c [-R] [-b 0|1] -d \n" "Add a submenu entry\n" " (-R is not needed)\n" -" menu -e -a -m -u -d \n" +" (-b for box style 1 for selected)\n" +" (and -c is not needed)\n" +" menu -e -a -m -u submenu -d [-b 0|1] \n" "\n" "Remove an entry\n" " menu -e -r -m -n \n" diff --git a/common/menu.c b/common/menu.c index 4307a07..0b8c8d9 100644 --- a/common/menu.c +++ b/common/menu.c @@ -152,10 +152,27 @@ void menu_entry_free(struct menu_entry *me) static void print_menu_entry(struct menu *m, struct menu_entry *me, int reverse) { gotoXY(me->num + 1, 3); - if (reverse) - printf_reverse("%d: %-*s", me->num, m->width, me->display); - else - printf("%d: %-*s", me->num, m->width, me->display); + if (reverse) { + if (me->type == MENU_ENTRY_BOX) { + if (me->box_state) + puts_reverse("[*]"); + else + puts_reverse("[ ]"); + } else { + printf_reverse(" "); + } + printf_reverse(" %d: %-*s", me->num, m->width, me->display); + } else { + if (me->type == MENU_ENTRY_BOX) { + if (me->box_state) + puts("[*]"); + else + puts("[ ]"); + } else { + puts(" "); + } + printf(" %d: %-*s", me->num, m->width, me->display); + } } int menu_set_selected_entry(struct menu *m, struct menu_entry* me) @@ -307,8 +324,18 @@ int menu_show(struct menu *m) } print_menu_entry(m, m->selected, 1); break; + case ' ': + if (m->selected->type != MENU_ENTRY_BOX) + break; + m->selected->box_state = !m->selected->box_state; + if (m->selected->action) + m->selected->action(m, m->selected); + print_menu_entry(m, m->selected, 1); + break; case '\n': case '\r': + if (m->selected->type == MENU_ENTRY_BOX) + break; clear(); gotoXY(1,1); m->selected->action(m, m->selected); @@ -336,6 +363,9 @@ static void menu_action_show(struct menu *m, struct menu_entry *me) struct submenu *s = container_of(me, struct submenu, entry); struct menu *sm; + if (me->type == MENU_ENTRY_BOX && !me->box_state) + return; + sm = menu_get_by_name(s->submenu); if (sm) menu_show(sm); @@ -411,7 +441,8 @@ static void menu_command_free(struct menu_entry *me) free(e); } -struct menu_entry *menu_add_command_entry(struct menu *m, char *display, char *command) +struct menu_entry *menu_add_command_entry(struct menu *m, char *display, + char *command, menu_entry_type type) { struct action_entry *e = calloc(1, sizeof(*e)); int ret; @@ -422,9 +453,10 @@ struct menu_entry *menu_add_command_entry(struct menu *m, char *display, char *c e->command = strdup(command); e->entry.action = menu_action_command; e->entry.free = menu_command_free; + e->entry.type = type; e->entry.display = strdup(display); - if (!e->entry.display || !e->command) { + if (!e->entry.display || (type != MENU_ENTRY_BOX && !e->command)) { ret = -ENOMEM; goto err_free; } diff --git a/include/menu.h b/include/menu.h index cc9d0af..6e7b555 100644 --- a/include/menu.h +++ b/include/menu.h @@ -28,6 +28,11 @@ struct menu; +typedef enum { + MENU_ENTRY_NORMAL = 0, + MENU_ENTRY_BOX, +} menu_entry_type; + struct menu_entry { int num; char *display; @@ -35,6 +40,12 @@ struct menu_entry { void (*free)(struct menu_entry *me); int non_re_ent; + /* MENU_ENTRY_BOX */ + int box_state; + void (*box_action)(struct menu *m, struct menu_entry *me); + + menu_entry_type type; + struct list_head list; }; @@ -69,7 +80,8 @@ static inline struct menu* menu_alloc(void) return m; } struct menu_entry *menu_add_submenu(struct menu *parent, char *submenu, char *display); -struct menu_entry *menu_add_command_entry(struct menu *m, char *display, char *command); +struct menu_entry *menu_add_command_entry(struct menu *m, char *display, + char *command, menu_entry_type type); void menu_free(struct menu *m); int menu_add(struct menu* m); void menu_remove(struct menu *m); -- 1.7.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox