mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marek Belisko <marek.belisko@open-nandra.com>
To: barebox@lists.infradead.org
Cc: Marek Belisko <marek.belisko@open-nandra.com>
Subject: [PATCH 2/5] fs: Fix sparse warning.
Date: Thu, 18 Nov 2010 14:29:28 +0100	[thread overview]
Message-ID: <1290086971-5467-3-git-send-email-marek.belisko@open-nandra.com> (raw)
In-Reply-To: <1290086971-5467-1-git-send-email-marek.belisko@open-nandra.com>

Patch fix following sparse warning:
fs/fs.c:757:28: warning: dubious: !x & y

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
 fs/fs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fs.c b/fs/fs.c
index 3b5f284..7d8dea7 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -754,7 +754,7 @@ int mount(const char *device, const char *fsname, const char *_path)
 	}
 
 	fsdev = xzalloc(sizeof(struct fs_device_d));
-	if (!fs_drv->flags & FS_DRIVER_NO_DEV) {
+	if (!(fs_drv->flags & FS_DRIVER_NO_DEV)) {
 		fsdev->backingstore = strdup(device);
 		if (!device) {
 			printf("need a device for driver %s\n", fsname);
-- 
1.7.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2010-11-18 13:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 13:29 [PATCH 0/5] Various sparse fixes Marek Belisko
2010-11-18 13:29 ` [PATCH 1/5] common: Add define for IOMEM helper macro Marek Belisko
2010-11-18 13:29 ` Marek Belisko [this message]
2010-11-19  8:36   ` [PATCH 2/5] fs: Fix sparse warning Sascha Hauer
2010-11-18 13:29 ` [PATCH 3/5] mtd: " Marek Belisko
2010-11-18 13:29 ` [PATCH 4/5] nand_s3c2410: Fix sparse warnings Marek Belisko
2010-11-18 13:29 ` [PATCH 5/5] smc91111: Various sparse fixes Marek Belisko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290086971-5467-3-git-send-email-marek.belisko@open-nandra.com \
    --to=marek.belisko@open-nandra.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox