mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 6/7] mci mxs: no need to call mxs_mci_setup_clock_speed in init
Date: Mon, 28 Feb 2011 10:43:54 +0100	[thread overview]
Message-ID: <1298886235-1769-7-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1298886235-1769-1-git-send-email-s.hauer@pengutronix.de>

It will be called by set_ios anyway later. Also, do not
alter host->clock field, this is none of our business.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mci/mxs.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mci/mxs.c b/drivers/mci/mxs.c
index 7f8f3f8..814eba3 100644
--- a/drivers/mci/mxs.c
+++ b/drivers/mci/mxs.c
@@ -615,7 +615,6 @@ static int mxs_mci_initialize(struct mci_host *host, struct device_d *mci_dev)
 	mxs_mci_reset(mxs_mci);
 
 	/* restore the last settings */
-	host->clock = mxs_mci->clock = mxs_mci_setup_clock_speed(mxs_mci, host->clock);
 	mxs_mci_setup_timeout(mxs_mci, 0xffff);
 	writel(SSP_CTRL0_IGNORE_CRC |
 		SSP_CTRL0_BUS_WIDTH(mxs_mci->bus_width),
@@ -678,9 +677,9 @@ static void mxs_mci_set_ios(struct mci_host *host, struct device_d *mci_dev,
 		break;
 	}
 
-	host->clock = mxs_mci->clock = mxs_mci_setup_clock_speed(mxs_mci, clock);
+	mxs_mci->clock = mxs_mci_setup_clock_speed(mxs_mci, clock);
 	pr_debug("IO settings: bus width=%d, frequency=%u Hz\n", host->bus_width,
-			host->clock);
+			mxs_mci->clock);
 }
 
 /* ----------------------------------------------------------------------- */
-- 
1.7.2.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2011-02-28  9:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28  9:43 mmc: i.MX23/28 patches Sascha Hauer
2011-02-28  9:43 ` [PATCH 1/7] mci i.MX23/28: rename driver to mxs.c Sascha Hauer
2011-02-28  9:43 ` [PATCH 2/7] mci mxs: put only once used function inline Sascha Hauer
2011-02-28  9:43 ` [PATCH 3/7] mci mxs: give functions a uniq mxs_mci_ namespace Sascha Hauer
2011-02-28  9:43 ` [PATCH 4/7] mci mxs: rename mci_pdata to host Sascha Hauer
2011-02-28  9:43 ` [PATCH 5/7] mci mxs: make the mci_host a member of mxs_mci_host Sascha Hauer
2011-02-28  9:43 ` Sascha Hauer [this message]
2011-02-28  9:43 ` [PATCH 7/7] ARM tx28stk5: limit mmc max frequency to 25MHz Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298886235-1769-7-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox