From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Juergen Beisert <jbe@kreuzholzen.de>
Subject: [PATCH 2/6] S3C24xx/NFC: Remove dead code
Date: Sat, 12 Mar 2011 20:14:53 +0100 [thread overview]
Message-ID: <1299957297-8539-3-git-send-email-jbe@pengutronix.de> (raw)
In-Reply-To: <1299957297-8539-1-git-send-email-jbe@pengutronix.de>
From: Juergen Beisert <jbe@kreuzholzen.de>
Something was to be done here. But I do not remember what. As it works also
without it, remove this dead code.
Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
---
drivers/mtd/nand/nand_s3c2410.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/nand_s3c2410.c b/drivers/mtd/nand/nand_s3c2410.c
index 6ee3b83..05a6a87 100644
--- a/drivers/mtd/nand/nand_s3c2410.c
+++ b/drivers/mtd/nand/nand_s3c2410.c
@@ -272,8 +272,7 @@ static int s3c2410_nand_correct_data(struct mtd_info *mtd, uint8_t *dat,
* to see if we have an 0xff,0xff,0xff read ECC and then ignore
* the error, on the assumption that this is an un-eccd page.
*/
- if (read_ecc[0] == 0xff && read_ecc[1] == 0xff && read_ecc[2] == 0xff
- /* && info->platform->ignore_unset_ecc */)
+ if (read_ecc[0] == 0xff && read_ecc[1] == 0xff && read_ecc[2] == 0xff)
return 0;
/* Can we correct this ECC (ie, one row and column change).
@@ -431,10 +430,7 @@ static int s3c24x0_nand_probe(struct device_d *dev)
mtd->priv = chip;
/* init the default settings */
-#if 0
- /* TODO: Will follow later */
- init_nand_chip_bw8(chip);
-#endif
+
/* 50 us command delay time */
chip->chip_delay = 50;
chip->priv = host;
--
1.7.2.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-03-12 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 19:14 [PATCH v3] S3C24xx: NAND management changes to support booting from NAND Juergen Beisert
2011-03-12 19:14 ` [PATCH 1/6] S3C24xx/NFC: Re-enable the controller after NAND boot test Juergen Beisert
2011-03-12 19:14 ` Juergen Beisert [this message]
2011-03-12 19:14 ` [PATCH 3/6] S3C24xx/NFC: Remove double function setup Juergen Beisert
2011-03-12 19:14 ` [PATCH 4/6] S3C24xx/NFC: Consider correct NAND page size for boot Juergen Beisert
2011-03-12 19:14 ` [PATCH 5/6] S3C24xx/NFC: Setup ECC handling in accordance to the kernel Juergen Beisert
2011-03-12 19:14 ` [PATCH 6/6] S3C24xx/NFC: Add OOB/ECC handling documentation for different NANDs Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299957297-8539-3-git-send-email-jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@kreuzholzen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox