mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 7/8] ARM: fix comments in interrupts.c
Date: Mon,  8 Aug 2011 08:46:42 +0200	[thread overview]
Message-ID: <1312786003-14734-8-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1312786003-14734-1-git-send-email-s.hauer@pengutronix.de>

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/cpu/interrupts.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/cpu/interrupts.c b/arch/arm/cpu/interrupts.c
index 71744ac..0c21bc1 100644
--- a/arch/arm/cpu/interrupts.c
+++ b/arch/arm/cpu/interrupts.c
@@ -97,8 +97,8 @@ void do_undefined_instruction (struct pt_regs *pt_regs)
  * The CPU catches a software interrupt
  * @param[in] pt_regs Register set content when the interrupt happens
  *
- * There is not functione behind this feature. So what to do else than
- * a reset? 
+ * There is no function behind this feature. So what to do else than
+ * a reset?
  */
 void do_software_interrupt (struct pt_regs *pt_regs)
 {
@@ -111,7 +111,7 @@ void do_software_interrupt (struct pt_regs *pt_regs)
  * The CPU catches a prefetch abort. That really should not happen!
  * @param[in] pt_regs Register set content when the accident happens
  *
- * FIXME: What does it mean, why is reset the only solution?
+ * instruction fetch from an unmapped area
  */
 void do_prefetch_abort (struct pt_regs *pt_regs)
 {
@@ -124,7 +124,7 @@ void do_prefetch_abort (struct pt_regs *pt_regs)
  * The CPU catches a data abort. That really should not happen!
  * @param[in] pt_regs Register set content when the accident happens
  *
- * FIXME: What does it mean, why is reset the only solution?
+ * data fetch from an unmapped area
  */
 void do_data_abort (struct pt_regs *pt_regs)
 {
@@ -137,7 +137,7 @@ void do_data_abort (struct pt_regs *pt_regs)
  * The CPU catches a fast interrupt request.
  * @param[in] pt_regs Register set content when the interrupt happens
  *
- * FIXME: What does it mean, why is reset the only solution?
+ * We never enable FIQs, so this should not happen
  */
 void do_fiq (struct pt_regs *pt_regs)
 {
@@ -150,7 +150,7 @@ void do_fiq (struct pt_regs *pt_regs)
  * The CPU catches a regular interrupt.
  * @param[in] pt_regs Register set content when the interrupt happens
  *
- * FIXME: What does it mean, why is reset the only solution?
+ * We never enable interrupts, so this should not happen
  */
 void do_irq (struct pt_regs *pt_regs)
 {
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2011-08-08  6:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08  6:46 ARM: use high vectors if possible Sascha Hauer
2011-08-08  6:46 ` [PATCH 1/8] ARM: add missing volatile in get_cr() Sascha Hauer
2011-08-08  6:46 ` [PATCH 2/8] ARM mmu: fix arm_create_pte Sascha Hauer
2011-08-08  6:46 ` [PATCH 3/8] ARM mmu: use high vectors if possible Sascha Hauer
2011-08-08  6:46 ` [PATCH 4/8] ARM: remove unused exception Sascha Hauer
2011-08-08  6:46 ` [PATCH 5/8] ARM: exceptions: remove unnecessary function declarations Sascha Hauer
2011-08-08  6:46 ` [PATCH 6/8] ARM: remove unused irq enable/disable functions Sascha Hauer
2011-08-08  6:46 ` Sascha Hauer [this message]
2011-08-08  6:46 ` [PATCH 8/8] ARM: some cleanup in interrupts.c Sascha Hauer
2011-08-08  7:06 ` ARM: use high vectors if possible Jean-Christophe PLAGNIOL-VILLARD
2011-08-08  7:32   ` Sascha Hauer
2011-08-09  7:36     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312786003-14734-8-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox