mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Teresa Gamez <T.Gamez@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Tim Sander <tim.sander@hbm.com>
Subject: Re: [PATCH] pcm memory fix
Date: Wed, 24 Aug 2011 08:20:18 +0200	[thread overview]
Message-ID: <1314166818.3389.127.camel@lws-gamez> (raw)
In-Reply-To: <20110823130607.GO31404@pengutronix.de>

Am Dienstag, den 23.08.2011, 15:06 +0200 schrieb Sascha Hauer:
> On Tue, Aug 23, 2011 at 02:30:01PM +0200, Tim Sander wrote:
> > This patch is inspired by ram_timing.patch from OSELAS.BSP-Phytec-phyCORE-i.MX35-PD10.1.2. 
> > PCM043 1315.6 does not boot without it.
> > 
> > Signed-off-by: Tim Sander <tim.sander@hbm.com>
> > 
> >     change refresh cycle
> 
> This is a duplicate of the patch Teresa recently sent. I just applied
> Teresas version.

Are there any reasons why you applied the first version of the patch and
not the second one with an updated description?

Teresa

> 
> Sascha
> 
> > 
> > diff --git a/arch/arm/boards/pcm043/lowlevel.c b/arch/arm/boards/pcm043/lowlevel.c
> > index eff96f9..bbe586b 100644
> > --- a/arch/arm/boards/pcm043/lowlevel.c
> > +++ b/arch/arm/boards/pcm043/lowlevel.c
> > @@ -146,7 +146,7 @@ void __bare_init __naked board_init_lowlevel(void)
> >         writel(0x00000304, ESDMISC); /* was 0x00000004 */
> >  
> >         /* set timing paramters */
> > -       writel(0x00255417, ESDCFG0);
> > +       writel(0x0025541F, ESDCFG0);
> >         /* select Precharge-All mode */
> >         writel(0x92220000, ESDCTL0);
> >         /* Precharge-All */
> > 
> > Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 
> > 
> > Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
> > Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster
> > 
> > Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
> > Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster
> > 
> > The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.
> > 
> > Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich fur den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> > 
> 



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-08-24  6:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23 12:30 Tim Sander
2011-08-23 13:06 ` Sascha Hauer
2011-08-24  6:20   ` Teresa Gamez [this message]
2011-08-24  8:32     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314166818.3389.127.camel@lws-gamez \
    --to=t.gamez@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=tim.sander@hbm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox