mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] at91sam9260ek: fix broken defconfig
@ 2011-09-14 21:10 Hubert Feurstein
  2011-09-14 21:10 ` [PATCH 2/2] at91sam9260: remove remaining 'at91_clock_associate' function Hubert Feurstein
  2011-09-15 13:15 ` [PATCH 1/2] at91sam9260ek: fix broken defconfig Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 2 replies; 4+ messages in thread
From: Hubert Feurstein @ 2011-09-14 21:10 UTC (permalink / raw)
  To: barebox

The defconfig was broken in commit

  cbf46b2 "at91: Support for at91rm9200: core chip & board support"

because ARCH_AT91RM9200 was added before ARCH_AT91SAM9260 in Kconfig.

Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 arch/arm/configs/at91sam9260ek_defconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/configs/at91sam9260ek_defconfig b/arch/arm/configs/at91sam9260ek_defconfig
index 6038aec..2d04206 100644
--- a/arch/arm/configs/at91sam9260ek_defconfig
+++ b/arch/arm/configs/at91sam9260ek_defconfig
@@ -1,3 +1,4 @@
+CONFIG_ARCH_AT91SAM9260=y
 CONFIG_ARM_OPTIMZED_STRING_FUNCTIONS=y
 CONFIG_LONGHELP=y
 CONFIG_GLOB=y
-- 
1.7.4.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] at91sam9260: remove remaining 'at91_clock_associate' function
  2011-09-14 21:10 [PATCH 1/2] at91sam9260ek: fix broken defconfig Hubert Feurstein
@ 2011-09-14 21:10 ` Hubert Feurstein
  2011-09-15 13:15   ` Jean-Christophe PLAGNIOL-VILLARD
  2011-09-15 13:15 ` [PATCH 1/2] at91sam9260ek: fix broken defconfig Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 1 reply; 4+ messages in thread
From: Hubert Feurstein @ 2011-09-14 21:10 UTC (permalink / raw)
  To: barebox

This fixes the following compile warning when MCI_ATMEL is selected:
  arch/arm/mach-at91/at91sam9260_devices.c: In function 'at91_add_device_mci':
  arch/arm/mach-at91/at91sam9260_devices.c:251:2: warning: implicit declaration of function 'at91_clock_associate'

Introduced in commit:
  "at91: swtich to clkdev" (ae19fe26cc230bc38238c2d66b8f464761286316)

Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 arch/arm/mach-at91/at91sam9260_devices.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-at91/at91sam9260_devices.c b/arch/arm/mach-at91/at91sam9260_devices.c
index 4540f4b..44d3f1e 100644
--- a/arch/arm/mach-at91/at91sam9260_devices.c
+++ b/arch/arm/mach-at91/at91sam9260_devices.c
@@ -248,7 +248,6 @@ void at91_add_device_mci(short mmc_id, struct atmel_mci_platform_data *data)
 
 	dev = add_generic_device("atmel_mci", 0, NULL, AT91SAM9260_BASE_MCI, SZ_16K,
 			   IORESOURCE_MEM, data);
-	at91_clock_associate("mci_clk", dev, "mci_clk");
 }
 #else
 void at91_add_device_mci(short mmc_id, struct atmel_mci_platform_data *data) {}
-- 
1.7.4.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] at91sam9260ek: fix broken defconfig
  2011-09-14 21:10 [PATCH 1/2] at91sam9260ek: fix broken defconfig Hubert Feurstein
  2011-09-14 21:10 ` [PATCH 2/2] at91sam9260: remove remaining 'at91_clock_associate' function Hubert Feurstein
@ 2011-09-15 13:15 ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2011-09-15 13:15 UTC (permalink / raw)
  To: Hubert Feurstein; +Cc: barebox

On 23:10 Wed 14 Sep     , Hubert Feurstein wrote:
> The defconfig was broken in commit
> 
>   cbf46b2 "at91: Support for at91rm9200: core chip & board support"
> 
> because ARCH_AT91RM9200 was added before ARCH_AT91SAM9260 in Kconfig.
in fact it's due to savedefconfig that remove the entry when we switch to the
new format not to the add of the rm9200 support

so please update the commit
> 
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] at91sam9260: remove remaining 'at91_clock_associate' function
  2011-09-14 21:10 ` [PATCH 2/2] at91sam9260: remove remaining 'at91_clock_associate' function Hubert Feurstein
@ 2011-09-15 13:15   ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 0 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2011-09-15 13:15 UTC (permalink / raw)
  To: Hubert Feurstein; +Cc: barebox

On 23:10 Wed 14 Sep     , Hubert Feurstein wrote:
> This fixes the following compile warning when MCI_ATMEL is selected:
>   arch/arm/mach-at91/at91sam9260_devices.c: In function 'at91_add_device_mci':
>   arch/arm/mach-at91/at91sam9260_devices.c:251:2: warning: implicit declaration of function 'at91_clock_associate'
> 
> Introduced in commit:
>   "at91: swtich to clkdev" (ae19fe26cc230bc38238c2d66b8f464761286316)
> 
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
please join it with 92g45 fix

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-09-15 13:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-14 21:10 [PATCH 1/2] at91sam9260ek: fix broken defconfig Hubert Feurstein
2011-09-14 21:10 ` [PATCH 2/2] at91sam9260: remove remaining 'at91_clock_associate' function Hubert Feurstein
2011-09-15 13:15   ` Jean-Christophe PLAGNIOL-VILLARD
2011-09-15 13:15 ` [PATCH 1/2] at91sam9260ek: fix broken defconfig Jean-Christophe PLAGNIOL-VILLARD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox