From: "Loïc Minier" <loic.minier@linaro.org>
To: barebox@lists.infradead.org
Subject: [PATCH 3/5] fprintf() returns an int
Date: Fri, 14 Oct 2011 00:06:39 +0200 [thread overview]
Message-ID: <1318543601-20819-4-git-send-email-loic.minier@linaro.org> (raw)
In-Reply-To: <1318543601-20819-1-git-send-email-loic.minier@linaro.org>
For consistency, let fprintf return an int just like it's regular libc
implementation and all the other printf variations barebox has. This
also fixes a warning on variable i being never read in the function.
Signed-off-by: Loïc Minier <loic.minier@linaro.org>
---
common/console.c | 4 +++-
include/stdio.h | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/console.c b/common/console.c
index 06e9c29..0d2a33b 100644
--- a/common/console.c
+++ b/common/console.c
@@ -327,7 +327,7 @@ void console_flush(void)
}
EXPORT_SYMBOL(console_flush);
-void fprintf (int file, const char *fmt, ...)
+int fprintf (int file, const char *fmt, ...)
{
va_list args;
uint i;
@@ -343,6 +343,8 @@ void fprintf (int file, const char *fmt, ...)
/* Print the string */
fputs (file, printbuffer);
+
+ return i;
}
EXPORT_SYMBOL(fprintf);
diff --git a/include/stdio.h b/include/stdio.h
index a0d81d3..0c68fa8 100644
--- a/include/stdio.h
+++ b/include/stdio.h
@@ -54,7 +54,7 @@ int vscnprintf(char *buf, size_t size, const char *fmt, va_list args);
#define stderr 2
#define MAX_FILES 128
-void fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
+int fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
int fputs(int file, const char *s);
int fputc(int file, const char c);
int ftstc(int file);
--
1.7.5.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-10-13 22:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 22:06 [RFC] Fix misc warnings when building sandbox on 64-bits Loïc Minier
2011-10-13 22:06 ` [PATCH 1/5] Only pass -P to cpp when generating ld scripts Loïc Minier
2011-10-13 22:06 ` [PATCH 2/5] Avoid warnings by using format(__printf__) Loïc Minier
2011-10-14 6:50 ` Sascha Hauer
2011-10-13 22:06 ` Loïc Minier [this message]
2011-10-14 7:04 ` [PATCH 3/5] fprintf() returns an int Sascha Hauer
2011-10-13 22:06 ` [PATCH 4/5] Use %p in format for pointers Loïc Minier
2011-10-14 7:18 ` Sascha Hauer
2011-10-14 7:22 ` Sascha Hauer
2011-10-13 22:06 ` [PATCH 5/5] Use size_t for memory offsets Loïc Minier
2011-10-14 7:20 ` Sascha Hauer
2011-10-14 8:59 ` Loïc Minier
2011-10-14 12:11 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318543601-20819-4-git-send-email-loic.minier@linaro.org \
--to=loic.minier@linaro.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox