* [PATCH] at91: add config option for ohci driver
@ 2011-11-09 16:03 Hubert Feurstein
2011-11-10 14:18 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-11 10:46 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 2 replies; 5+ messages in thread
From: Hubert Feurstein @ 2011-11-09 16:03 UTC (permalink / raw)
To: barebox
Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
drivers/usb/host/Kconfig | 4 ++++
drivers/usb/host/Makefile | 2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 929eb89..96e09e2 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -7,3 +7,7 @@ config USB_EHCI_OMAP
config USB_OHCI
bool "OHCI driver"
+
+config USB_OHCI_AT91
+ depends on ARCH_AT91
+ bool "AT91 OHCI driver"
diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
index 1c7e18f..00f5e24 100644
--- a/drivers/usb/host/Makefile
+++ b/drivers/usb/host/Makefile
@@ -1,4 +1,4 @@
obj-$(CONFIG_USB_EHCI) += ehci-hcd.o
obj-$(CONFIG_USB_EHCI_OMAP) += ehci-omap.o
obj-$(CONFIG_USB_OHCI) += ohci-hcd.o
-obj-$(CONFIG_ARCH_AT91) += ohci-at91.o
+obj-$(CONFIG_USB_OHCI_AT91) += ohci-at91.o
--
1.7.4.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] at91: add config option for ohci driver
2011-11-09 16:03 [PATCH] at91: add config option for ohci driver Hubert Feurstein
@ 2011-11-10 14:18 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-10 17:03 ` Hubert Feurstein
2011-11-11 10:46 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 1 reply; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2011-11-10 14:18 UTC (permalink / raw)
To: Hubert Feurstein; +Cc: barebox
On 17:03 Wed 09 Nov , Hubert Feurstein wrote:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> drivers/usb/host/Kconfig | 4 ++++
> drivers/usb/host/Makefile | 2 +-
> 2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 929eb89..96e09e2 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -7,3 +7,7 @@ config USB_EHCI_OMAP
>
> config USB_OHCI
> bool "OHCI driver"
> +
> +config USB_OHCI_AT91
> + depends on ARCH_AT91
> + bool "AT91 OHCI driver"
> diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
> index 1c7e18f..00f5e24 100644
> --- a/drivers/usb/host/Makefile
> +++ b/drivers/usb/host/Makefile
> @@ -1,4 +1,4 @@
> obj-$(CONFIG_USB_EHCI) += ehci-hcd.o
> obj-$(CONFIG_USB_EHCI_OMAP) += ehci-omap.o
> obj-$(CONFIG_USB_OHCI) += ohci-hcd.o
> -obj-$(CONFIG_ARCH_AT91) += ohci-at91.o
> +obj-$(CONFIG_USB_OHCI_AT91) += ohci-at91.o
no need such config
on AT91 you just need to enable the OCHI
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] at91: add config option for ohci driver
2011-11-10 14:18 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2011-11-10 17:03 ` Hubert Feurstein
0 siblings, 0 replies; 5+ messages in thread
From: Hubert Feurstein @ 2011-11-10 17:03 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
2011/11/10 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
[snip]
>> -obj-$(CONFIG_ARCH_AT91) += ohci-at91.o
>> +obj-$(CONFIG_USB_OHCI_AT91) += ohci-at91.o
> no need such config
>
> on AT91 you just need to enable the OCHI
>
> Best Regards,
> J.
>
without that the ohci-at91 is _always_ compiled and linked into
barebox, even when 'USB support' is unselected.
Best Regards
Hubert
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] at91: add config option for ohci driver
2011-11-09 16:03 [PATCH] at91: add config option for ohci driver Hubert Feurstein
2011-11-10 14:18 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2011-11-11 10:46 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-11 11:05 ` Sascha Hauer
1 sibling, 1 reply; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2011-11-11 10:46 UTC (permalink / raw)
To: Hubert Feurstein; +Cc: barebox
On 17:03 Wed 09 Nov , Hubert Feurstein wrote:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> drivers/usb/host/Kconfig | 4 ++++
> drivers/usb/host/Makefile | 2 +-
> 2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 929eb89..96e09e2 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -7,3 +7,7 @@ config USB_EHCI_OMAP
>
> config USB_OHCI
> bool "OHCI driver"
> +
> +config USB_OHCI_AT91
> + depends on ARCH_AT91
> + bool "AT91 OHCI driver"
Sacahs can you revert this one
there is no need to have any select for the user
if you enalbe the OHCI it must just enable it on AT91 directly otherwise you
have a OHCI enable but without driver
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] at91: add config option for ohci driver
2011-11-11 10:46 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2011-11-11 11:05 ` Sascha Hauer
0 siblings, 0 replies; 5+ messages in thread
From: Sascha Hauer @ 2011-11-11 11:05 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On Fri, Nov 11, 2011 at 11:46:14AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:03 Wed 09 Nov , Hubert Feurstein wrote:
> > Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > drivers/usb/host/Kconfig | 4 ++++
> > drivers/usb/host/Makefile | 2 +-
> > 2 files changed, 5 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > index 929eb89..96e09e2 100644
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -7,3 +7,7 @@ config USB_EHCI_OMAP
> >
> > config USB_OHCI
> > bool "OHCI driver"
> > +
> > +config USB_OHCI_AT91
> > + depends on ARCH_AT91
> > + bool "AT91 OHCI driver"
> Sacahs can you revert this one
>
> there is no need to have any select for the user
>
> if you enalbe the OHCI it must just enable it on AT91 directly otherwise you
> have a OHCI enable but without driver
What the patch fixes is that ohci-at91.c is compiled even when USB is
completely disabled, so reverting just it is not a good solution. I'm
open to better solutions.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-11 11:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-09 16:03 [PATCH] at91: add config option for ohci driver Hubert Feurstein
2011-11-10 14:18 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-10 17:03 ` Hubert Feurstein
2011-11-11 10:46 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-11 11:05 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox