From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 07/14] bootm: handle initrds inline
Date: Mon, 28 Nov 2011 09:02:13 +0100 [thread overview]
Message-ID: <1322467340-10596-8-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1322467340-10596-1-git-send-email-s.hauer@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
commands/bootm.c | 78 +++++++++++++++++++----------------------------------
1 files changed, 28 insertions(+), 50 deletions(-)
diff --git a/commands/bootm.c b/commands/bootm.c
index 823d387..17139f7 100644
--- a/commands/bootm.c
+++ b/commands/bootm.c
@@ -141,55 +141,6 @@ static struct image_handle *get_fake_image_handle(struct image_data *data, int n
return handle;
}
-static int initrd_handler_parse_options(struct image_data *data, int opt,
- char *optarg)
-{
- uint32_t initrd_start;
-
- switch(opt) {
- case 'L':
- if (!data->initrd) {
- eprintf("Warning -L ingnored. Specify the initrd first\n");
- break;
- }
- initrd_start = simple_strtoul(optarg, NULL, 0);
- printf("initrd_start=0x%x\n", initrd_start);
- data->initrd->header.ih_load = cpu_to_uimage(initrd_start);
- break;
- case 'r':
- printf("use initrd %s\n", optarg);
- /* check for multi image @<num> */
- if (optarg[0] == '@') {
- int num = simple_strtol(optarg + 1, NULL, 0);
-
- data->initrd = get_fake_image_handle(data, num);
- } else {
- data->initrd = map_image(optarg, data->verify);
- }
- if (!data->initrd)
- return -1;
- break;
- default:
- return 1;
- }
-
- return 0;
-}
-
-static struct image_handler initrd_handler = {
- .cmdline_options = "r:L:",
- .cmdline_parse = initrd_handler_parse_options,
- .help_string = " -r <initrd> specify an initrd image\n"
- " -L <load addr> specify initrd load address",
-};
-
-static int initrd_register_image_handler(void)
-{
- return register_image_handler(&initrd_handler);
-}
-
-late_initcall(initrd_register_image_handler);
-
static int handler_parse_options(struct image_data *data, int opt, char *optarg)
{
struct image_handler *handler;
@@ -216,13 +167,14 @@ static int do_bootm(struct command *cmdtp, int argc, char *argv[])
struct image_handle *os_handle, *initrd_handle = NULL;
struct image_handler *handler;
struct image_data data;
+ u32 initrd_start;
char options[53]; /* worst case: whole alphabet with colons */
memset(&data, 0, sizeof(struct image_data));
data.verify = 1;
/* Collect options from registered handlers */
- strcpy(options, "nh");
+ strcpy(options, "nhr:L:");
list_for_each_entry(handler, &handler_list, list) {
if (handler->cmdline_options)
strcat(options, handler->cmdline_options);
@@ -242,6 +194,28 @@ static int do_bootm(struct command *cmdtp, int argc, char *argv[])
}
return 0;
+ case 'L':
+ if (!data.initrd) {
+ eprintf("Warning -L ingnored. Specify the initrd first\n");
+ break;
+ }
+ initrd_start = simple_strtoul(optarg, NULL, 0);
+ printf("initrd_start=0x%x\n", initrd_start);
+ data.initrd->header.ih_load = cpu_to_uimage(initrd_start);
+ break;
+ case 'r':
+ printf("use initrd %s\n", optarg);
+ /* check for multi image @<num> */
+ if (optarg[0] == '@') {
+ int num = simple_strtol(optarg + 1, NULL, 0);
+
+ data.initrd = get_fake_image_handle(&data, num);
+ } else {
+ data.initrd = map_image(optarg, data.verify);
+ }
+ if (!data.initrd)
+ return -1;
+ break;
default:
break;
}
@@ -269,6 +243,8 @@ static int do_bootm(struct command *cmdtp, int argc, char *argv[])
switch(opt) {
case 'h':
case 'n':
+ case 'L':
+ case 'r':
break;
default:
if (!handler_parse_options(&data, opt, optarg))
@@ -310,6 +286,8 @@ BAREBOX_CMD_HELP_START(bootm)
BAREBOX_CMD_HELP_USAGE("bootm [-n] image\n")
BAREBOX_CMD_HELP_SHORT("Boot an application image.\n")
BAREBOX_CMD_HELP_OPT ("-n", "Do not verify the image (speeds up boot process)\n")
+BAREBOX_CMD_HELP_OPT ("-r <initrd>","specify an initrd image\n")
+BAREBOX_CMD_HELP_OPT ("-L <load addr>","specify initrd load address")
BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(bootm)
--
1.7.7.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-11-28 8:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 8:02 bootm work Sascha Hauer
2011-11-28 8:02 ` [PATCH 01/14] bootm: remove dead code Sascha Hauer
2011-11-28 8:02 ` [PATCH 02/14] factor out iminfo command Sascha Hauer
2011-11-28 8:02 ` [PATCH 03/14] compile in simple_strtoull Sascha Hauer
2011-11-28 8:02 ` [PATCH 04/14] introduce some env helpers Sascha Hauer
2011-11-28 8:02 ` [PATCH 05/14] armlinux: cleanup linux vars Sascha Hauer
2011-11-28 11:03 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-28 11:12 ` Sascha Hauer
2011-11-29 4:38 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-29 7:23 ` Robert Schwebel
2011-11-29 8:13 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-29 10:09 ` Sascha Hauer
2011-11-28 8:02 ` [PATCH 06/14] ARM bootm: remove now obsolete args Sascha Hauer
2011-11-28 8:02 ` Sascha Hauer [this message]
2011-12-06 15:08 ` [PATCH 07/14] bootm: handle initrds inline Jean-Christophe PLAGNIOL-VILLARD
2011-12-07 9:19 ` Sascha Hauer
2011-12-07 13:26 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-28 8:02 ` [PATCH 08/14] bootm: remove image handler options Sascha Hauer
2011-11-28 8:02 ` [PATCH 09/14] bootm: fix various memory leaks Sascha Hauer
2011-11-28 8:02 ` [PATCH 10/14] bootm: do not require -L after -r Sascha Hauer
2011-11-28 8:02 ` [PATCH 11/14] bootm: fix typo, update help str Sascha Hauer
2011-11-28 11:00 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-28 8:02 ` [PATCH 12/14] bootm relocate_image: honour load_address Sascha Hauer
2011-11-28 8:02 ` [PATCH 13/14] bootm: push relocate_image up to the generic command Sascha Hauer
2011-11-28 8:02 ` [PATCH 14/14] bootm: use initrd_address and initrd_size Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322467340-10596-8-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox