From: Teresa Gamez <T.Gamez@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Steve Schefter <steve@scheftech.com>, barebox@lists.infradead.org
Subject: Re: [PATCH] nand_omap_bch_decoder: Fix up error detection
Date: Wed, 21 Dec 2011 14:18:38 +0100 [thread overview]
Message-ID: <1324473518.18539.45.camel@lws-gamez> (raw)
In-Reply-To: <1323424858-14282-1-git-send-email-t.gamez@phytec.de>
Am Freitag, den 09.12.2011, 11:00 +0100 schrieb Teresa Gámez:
> From: Steve Schefter <steve@scheftech.com>
>
> Bit errors in the ECC itself are not beeing taken into account.
> In this cases the number of detected errors != number of corrected errors and
> chien search returns an error.
> This patch adds detection of bit errors in the ECC.
>
> Signed-off-by: Steve Schefter <steve@scheftech.com>
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
Ping?
Regards
Teresa
> ---
> drivers/mtd/nand/nand_omap_bch_decoder.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_omap_bch_decoder.c b/drivers/mtd/nand/nand_omap_bch_decoder.c
> index 356f71f..d1455e4 100644
> --- a/drivers/mtd/nand/nand_omap_bch_decoder.c
> +++ b/drivers/mtd/nand/nand_omap_bch_decoder.c
> @@ -64,6 +64,7 @@ static int chien(unsigned int select_4_8, int err_nums,
> unsigned int err[], unsigned int *location)
> {
> int i, count; /* Number of dectected errors */
> + int errorsinecc; /* Number of detected errors in ECC bits */
> /* Contains accumulation of evaluation at x^i (i:1->8) */
> unsigned int gammas[8] = {0};
> unsigned int alpha;
> @@ -77,7 +78,8 @@ static int chien(unsigned int select_4_8, int err_nums,
> gammas[i] = err[i];
>
> count = 0;
> - for (i = 1; (i <= nn) && (count < err_nums); i++) {
> + errorsinecc = 0;
> + for (i = 1; (i <= nn) && ((count + errorsinecc) < err_nums); i++) {
>
> /* Result of evaluation at root */
> elp_sum = 1 ^ gammas[0] ^ gammas[1] ^
> @@ -108,11 +110,13 @@ static int chien(unsigned int select_4_8, int err_nums,
> if (i >= 2 * ecc_bits)
> location[count++] =
> kk_shorten - (bit - 2 * ecc_bits) - 1;
> + else
> + errorsinecc++;
> }
> }
>
> /* Failure: No. of detected errors != No. or corrected errors */
> - if (count != err_nums) {
> + if ((count + errorsinecc) != err_nums) {
> count = -1;
> printk(KERN_ERR "BCH decoding failed\n");
> }
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-12-21 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 10:00 Teresa Gámez
2011-12-21 13:18 ` Teresa Gamez [this message]
2012-01-02 11:45 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324473518.18539.45.camel@lws-gamez \
--to=t.gamez@phytec.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=steve@scheftech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox