[PATCH] fs: fat: gen_numname() is only need with FS_FAT_WRITE

[PATCH] fs: fat: gen_numname() is only need with FS_FAT_WRITE

[Wolfram Sang]

So, check for that config option, too. This will get rid of the warning:

	fs/fat/ff.c:878:13: warning: 'gen_numname' defined but not used

I could have also moved the function further down, but I decided for the
least intrusive change.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
 fs/fat/ff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fat/ff.c b/fs/fat/ff.c
index 3ada867..0087e21 100644
--- a/fs/fat/ff.c
+++ b/fs/fat/ff.c
@@ -874,7 +874,7 @@ void fit_lfn (
 /*
  * Create numbered name
  */
-#ifdef CONFIG_FS_FAT_LFN
+#if defined(CONFIG_FS_FAT_LFN) && defined(CONFIG_FS_FAT_WRITE)
 static void gen_numname (
 	BYTE *dst,		/* Pointer to generated SFN */
 	const BYTE *src,	/* Pointer to source SFN to be modified */
-- 
1.7.7.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fs: fat: gen_numname() is only need with FS_FAT_WRITE

[Sascha Hauer]

On Thu, Jan 05, 2012 at 08:18:15PM +0100, Wolfram Sang wrote:
> So, check for that config option, too. This will get rid of the warning:
> 
> 	fs/fat/ff.c:878:13: warning: 'gen_numname' defined but not used
> 
> I could have also moved the function further down, but I decided for the
> least intrusive change.

I already posted the same patch.

Sascha

> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  fs/fat/ff.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/fat/ff.c b/fs/fat/ff.c
> index 3ada867..0087e21 100644
> --- a/fs/fat/ff.c
> +++ b/fs/fat/ff.c
> @@ -874,7 +874,7 @@ void fit_lfn (
>  /*
>   * Create numbered name
>   */
> -#ifdef CONFIG_FS_FAT_LFN
> +#if defined(CONFIG_FS_FAT_LFN) && defined(CONFIG_FS_FAT_WRITE)
>  static void gen_numname (
>  	BYTE *dst,		/* Pointer to generated SFN */
>  	const BYTE *src,	/* Pointer to source SFN to be modified */
> -- 
> 1.7.7.3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fs: fat: gen_numname() is only need with FS_FAT_WRITE

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 664 bytes --]

On Fri, Jan 06, 2012 at 09:29:18AM +0100, Sascha Hauer wrote:
> On Thu, Jan 05, 2012 at 08:18:15PM +0100, Wolfram Sang wrote:
> > So, check for that config option, too. This will get rid of the warning:
> > 
> > 	fs/fat/ff.c:878:13: warning: 'gen_numname' defined but not used
> > 
> > I could have also moved the function further down, but I decided for the
> > least intrusive change.
> 
> I already posted the same patch.

Ah, now I found it. Terrible patch description, if I may say so ;)

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox