From: Sanjeev Premi <premi@ti.com>
To: barebox@lists.infradead.org
Subject: [PATCH 2/5] ARM omap3beagle: Fix incorrect base addresses
Date: Wed, 11 Jan 2012 20:27:19 +0530 [thread overview]
Message-ID: <1326293842-3063-3-git-send-email-premi@ti.com> (raw)
In-Reply-To: <s.hauer@pengutronix.de,plagnioj@jcrosoft.com,J.Kilb@phytec.de>
The base address passed for device "omap-hsmmc" was
incorrectly passed as OMAP_I2C1_BASE and the base
address for device "i2c-omap" was hardcoded to
0x4809C000 which, in fact, refers to OMAP_MMC1_BASE.
Similarly, in call to add_usb_ehci_device(), addition
is not required if right base address is used.
In fact, 0x48064700 (used as base in the addition)
falls in the OHCI Address space.
Signed-off-by: Sanjeev Premi <premi@ti.com>
---
Changes are straight forward address replacement.
Still, plan to test later today.
arch/arm/boards/omap/board-beagle.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boards/omap/board-beagle.c b/arch/arm/boards/omap/board-beagle.c
index 5f8c2df..9f0acad 100644
--- a/arch/arm/boards/omap/board-beagle.c
+++ b/arch/arm/boards/omap/board-beagle.c
@@ -290,13 +290,13 @@ mem_initcall(beagle_mem_init);
static int beagle_devices_init(void)
{
i2c_register_board_info(0, i2c_devices, ARRAY_SIZE(i2c_devices));
- add_generic_device("i2c-omap", -1, NULL, 0x4809C000, SZ_4K,
+ add_generic_device("i2c-omap", -1, NULL, OMAP_I2C1_BASE, SZ_4K,
IORESOURCE_MEM, NULL);
#ifdef CONFIG_USB_EHCI_OMAP
if (ehci_omap_init(&omap_ehci_pdata) >= 0)
- add_usb_ehci_device(-1, 0x48064700 + 0x100,
- 0x48064700 + 0x110, &ehci_pdata);
+ add_usb_ehci_device(-1, OMAP_EHCI_BASE,
+ OMAP_EHCI_BASE + 0x10, &ehci_pdata);
#endif /* CONFIG_USB_EHCI_OMAP */
#ifdef CONFIG_OMAP_GPMC
/* WP is made high and WAIT1 active Low */
@@ -304,7 +304,7 @@ static int beagle_devices_init(void)
#endif
gpmc_generic_nand_devices_init(0, 16, OMAP_ECC_HAMMING_CODE_HW_ROMCODE);
- add_generic_device("omap-hsmmc", -1, NULL, OMAP_I2C1_BASE, 0,
+ add_generic_device("omap-hsmmc", -1, NULL, OMAP_MMC1_BASE, SZ_4K,
IORESOURCE_MEM, NULL);
armlinux_set_bootparams((void *)0x80000100);
--
1.7.0.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-01-11 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <s.hauer@pengutronix.de,plagnioj@jcrosoft.com,J.Kilb@phytec.de>
2012-01-11 14:57 ` [PATCH 0/5] ARM omap: Some fixes and enhancements Sanjeev Premi
2012-01-11 17:32 ` Premi, Sanjeev
2012-01-11 17:52 ` Premi, Sanjeev
2012-01-11 14:57 ` [PATCH 1/5] ARM omap: Use updated config option Sanjeev Premi
2012-01-11 14:57 ` Sanjeev Premi [this message]
2012-01-11 14:57 ` [PATCH 3/5] ARM omap3evm: Allow building first stage bootloader Sanjeev Premi
2012-01-11 14:57 ` [PATCH 4/5] ARM omap3evm: Enable HSMMC device Sanjeev Premi
2012-01-11 14:57 ` [PATCH 5/5] ARM omap: Set IFT target as MLO Sanjeev Premi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326293842-3063-3-git-send-email-premi@ti.com \
--to=premi@ti.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox