mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [RFC] fix gpmc_nand_probe without param support
@ 2012-01-13 12:49 Jan Weitzel
  0 siblings, 0 replies; only message in thread
From: Jan Weitzel @ 2012-01-13 12:49 UTC (permalink / raw)
  To: barebox

commit 30de24d79fc6e659d0070f6e863ae0e53567ba0e param: add config to disable it
removes param support for xloader configurations. Set param eccmode calls
omap_gpmc_eccmode and so nand_scan_tail. So nand fails without param support

Call omap_gpmc_eccmode directly if CONFIG_PARAMETER is not enabled
to fix that.

Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
---
Because my xloader is still to big (50480 due to nand support), 
only rarely tested.


 drivers/mtd/nand/nand_omap_gpmc.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/nand/nand_omap_gpmc.c b/drivers/mtd/nand/nand_omap_gpmc.c
index 3bb6d79..d55dcaa 100644
--- a/drivers/mtd/nand/nand_omap_gpmc.c
+++ b/drivers/mtd/nand/nand_omap_gpmc.c
@@ -959,6 +959,9 @@ static int gpmc_nand_probe(struct device_d *pdev)
 	dev_add_param(pdev, "eccmode", omap_gpmc_eccmode_set, NULL, 0);
 	dev_set_param(pdev, "eccmode", ecc_mode_strings[pdata->ecc_mode]);
 
+	if (! IS_ENABLED(CONFIG_PARAMETER))
+		omap_gpmc_eccmode(oinfo, pdata->ecc_mode);
+
 	/* We are all set to register with the system now! */
 	err = add_mtd_device(minfo, "nand");
 	if (err) {
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-01-13 12:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-13 12:49 [RFC] fix gpmc_nand_probe without param support Jan Weitzel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox