mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 5/7] initcalls: do not hang if an initcall fails
Date: Thu, 26 Jan 2012 14:26:51 +0100	[thread overview]
Message-ID: <1327584413-23055-6-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1327584413-23055-1-git-send-email-s.hauer@pengutronix.de>

Currently we just hang when an initcall fails. This resulted
in most initcalls just returning 0 unconditionally. Instead
of hanging which usually leaves the user without a clue what
happened just continue and hope for the best.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/startup.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/common/startup.c b/common/startup.c
index 180fdc3..d39748b 100644
--- a/common/startup.c
+++ b/common/startup.c
@@ -124,10 +124,7 @@ void start_barebox (void)
 		PUTS_LL("<<");
 		PUTHEX_LL(*initcall);
 		result = (*initcall)();
-		PUTC_LL('>');
-		if (result)
-			hang();
-		PUTS_LL(">\n");
+		PUTS_LL(">>\n");
 	}
 
 	PUTS_LL("initcalls done\n");
-- 
1.7.8.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2012-01-26 13:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-26 13:26 some debug patches Sascha Hauer
2012-01-26 13:26 ` [PATCH 1/7] console: remove unused function prototypes Sascha Hauer
2012-01-26 13:26 ` [PATCH 2/7] kfifo: change kfifo_init to work with a preallocated fifo Sascha Hauer
2012-01-26 13:26 ` [PATCH 3/7] console: make it work without malloc Sascha Hauer
2012-01-26 13:26 ` [PATCH 4/7] ARM: panic on div 0 Sascha Hauer
2012-01-26 13:26 ` Sascha Hauer [this message]
2012-01-26 13:26 ` [PATCH 6/7] startup: use regular debug statements in initcall debugging Sascha Hauer
2012-01-26 13:26 ` [PATCH 7/7] Add dump_stack function Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327584413-23055-6-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox