mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sanjeev Premi <premi@ti.com>
To: barebox@lists.infradead.org
Subject: [PATCH v2] omap: xload: Make error more specific
Date: Mon, 13 Feb 2012 15:39:01 +0530	[thread overview]
Message-ID: <1329127741-2672-1-git-send-email-premi@ti.com> (raw)

Current message indicating that SD card isn't
mounted is misleading if the card has only one
partition.

Updated the message to indicate that mounting
the specific partition failed.

Signed-off-by: Sanjeev Premi <premi@ti.com>
---
 Changes since v1:
   Use variable diskdev to ensure that name of device
   used in the mount() and error message continue to
   remain in sync.


 arch/arm/mach-omap/xload.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap/xload.c b/arch/arm/mach-omap/xload.c
index a52a8ba..59f75e2 100644
--- a/arch/arm/mach-omap/xload.c
+++ b/arch/arm/mach-omap/xload.c
@@ -37,10 +37,11 @@ void *omap_xload_boot_mmc(void)
 	int ret;
 	void *buf;
 	int len;
+	const char *diskdev = "disk0.0";
 
-	ret = mount("disk0.0", "fat", "/");
+	ret = mount(diskdev, "fat", "/");
 	if (ret) {
-		printf("mounting sd card failed with %d\n", ret);
+		printf("Unable to mount %s (%d)\n", diskdev, ret);
 		return NULL;
 	}
 
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2012-02-13 10:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 10:09 Sanjeev Premi [this message]
2012-02-14 11:10 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329127741-2672-1-git-send-email-premi@ti.com \
    --to=premi@ti.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox