[PATCH] imx27-regs: fix .h usage in assembly file

[PATCH] imx27-regs: fix .h usage in assembly file

[Eric Bénard]

7ab0a0a i.MX27: Added helper for setup chipselect control register
added an helper which triggers the following error :
arch/arm/mach-imx/include/mach/imx27-regs.h:243: Error: bad instruction `static inline void imx27_setup_weimcs(size_t cs,unsigned upper,unsigned lower,unsigned addional)'

This patch fix this problem.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 arch/arm/mach-imx/include/mach/imx27-regs.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-imx/include/mach/imx27-regs.h b/arch/arm/mach-imx/include/mach/imx27-regs.h
index 25ea04a..437cc7d 100644
--- a/arch/arm/mach-imx/include/mach/imx27-regs.h
+++ b/arch/arm/mach-imx/include/mach/imx27-regs.h
@@ -240,11 +240,13 @@
 #define IMX_CS4_BASE	0xD4000000
 #define IMX_CS5_BASE	0xD6000000
 
+#ifndef __ASSEMBLY__
 static inline void imx27_setup_weimcs(size_t cs, unsigned upper, unsigned lower, unsigned addional)
 {
 	CSxU(cs) = upper;
 	CSxL(cs) = lower;
 	CSxA(cs) = addional;
 }
+#endif /* __ASSEMBLY__ */
 
 #endif /* _IMX27_REGS_H */
-- 
1.7.7.6


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] imx27-regs: fix .h usage in assembly file

[Eric Bénard]

Le Thu,  5 Apr 2012 11:41:36 +0200,
Eric Bénard <eric@eukrea.com> a écrit :

> 7ab0a0a i.MX27: Added helper for setup chipselect control register
> added an helper which triggers the following error :
> arch/arm/mach-imx/include/mach/imx27-regs.h:243: Error: bad instruction `static inline void imx27_setup_weimcs(size_t cs,unsigned upper,unsigned lower,unsigned addional)'
> 
> This patch fix this problem.
> 
and should also fix :
mx27ads_defconfig
neso_defconfig
pca100_defconfig

Eric

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] imx27-regs: fix .h usage in assembly file

[Sascha Hauer]

On Thu, Apr 05, 2012 at 11:41:36AM +0200, Eric Bénard wrote:
> 7ab0a0a i.MX27: Added helper for setup chipselect control register
> added an helper which triggers the following error :
> arch/arm/mach-imx/include/mach/imx27-regs.h:243: Error: bad instruction `static inline void imx27_setup_weimcs(size_t cs,unsigned upper,unsigned lower,unsigned addional)'
> 
> This patch fix this problem.
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>

Thanks, Eric. You are my hero of the day. I applied your patches except
the ones Jean-Christophe commented on. I assume he will come up with
another solution.

Thanks
 Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox