mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] bootm: be more informative with oftrees
@ 2012-04-13 13:08 Sascha Hauer
  0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2012-04-13 13:08 UTC (permalink / raw)
  To: barebox

- print error message when the specified oftree cannot be opened
- move verbose info to top of function so that the information is
  printed before something else fails.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 commands/bootm.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/commands/bootm.c b/commands/bootm.c
index 4f174db..1e1dc52 100644
--- a/commands/bootm.c
+++ b/commands/bootm.c
@@ -154,9 +154,14 @@ static int bootm_open_oftree(struct image_data *data, char *oftree, int num)
 	int ret;
 	size_t size;
 
+	if (bootm_verbose(data))
+		printf("Loading oftree from '%s'\n", oftree);
+
 	ft = file_name_detect_type(oftree);
-	if ((int)ft < 0)
+	if ((int)ft < 0) {
+		printf("failed to open %s: %s\n", oftree, strerror(-(int)ft));
 		return ft;
+	}
 
 	if (ft == filetype_uimage) {
 #ifdef CONFIG_CMD_BOOTM_OFTREE_UIMAGE
@@ -196,9 +201,6 @@ static int bootm_open_oftree(struct image_data *data, char *oftree, int num)
 				file_type_to_string(ft));
 	}
 
-	if (bootm_verbose(data))
-		printf("Loading oftree from '%s'\n", oftree);
-
 	fdt = xrealloc(fdt, size + 0x8000);
 	fdt_open_into(fdt, fdt, size + 0x8000);
 
-- 
1.7.10


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-04-13 13:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-13 13:08 [PATCH] bootm: be more informative with oftrees Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox