[PATCH 1/1] complete: fix duplicate env eval list

[PATCH 1/1] complete: fix duplicate env eval list

[Jean-Christophe PLAGNIOL-VILLARD]

this can be reproductable by this sequence

barebox:/ <TAB>
.                  ?                  [                  addpart
bootm              cat                cd                 clear
cp                 cpuinfo            crc32              delpart
devinfo            dhcp               echo               edit
erase              ethact             exit               export
false              getopt             go                 help
host               loadb              loadenv            loady
login              ls                 md                 md5sum
memcmp             memcpy             meminfo            memset
menu               mkdir              mount              mtest
mw                 nfs                passwd             ping
printenv           protect            pwd                readline
reset              rm                 rmdir              saveenv
sedit              sh                 sha1sum            sha256sum
sleep              source             test               tftp
time               timeout            true               umount
uncompress         unprotect          version            net.nameserver=
net.domainname=    cs0.baudrate=      cs0.active=        cs1.active=
cs1.ip=            cs1.port=
barebox:/ $<TAB>
$net.nameserver     $net.domainname     $cs0.baudrate
$cs0.active         $cs1.active         $cs1.ip
$cs1.port           $net.nameserver     $net.domainname
$cs0.baudrate       $cs0.active         $cs1.active
$cs1.ip             $cs1.port
barebox:/ $

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 common/complete.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/complete.c b/common/complete.c
index 0b03d7c..0780888 100644
--- a/common/complete.c
+++ b/common/complete.c
@@ -272,7 +272,7 @@ static char* cmd_complete_lookup(struct string_list *sl, char *instr)
 {
 	struct command *cmdtp;
 	int len;
-	int ret = 1;
+	int ret = COMPLETE_END;
 	char *res = NULL;
 
 	for_each_command(cmdtp) {
-- 
1.7.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/1] complete: fix duplicate env eval list

[Antony Pavlov]

I have just checked this patch.
The patch fixes the problem with dubbing.

On 3 May 2012 12:01, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> this can be reproductable by this sequence
>
> barebox:/ <TAB>
> .                  ?                  [                  addpart
> bootm              cat                cd                 clear
> cp                 cpuinfo            crc32              delpart
> devinfo            dhcp               echo               edit
> erase              ethact             exit               export
> false              getopt             go                 help
> host               loadb              loadenv            loady
> login              ls                 md                 md5sum
> memcmp             memcpy             meminfo            memset
> menu               mkdir              mount              mtest
> mw                 nfs                passwd             ping
> printenv           protect            pwd                readline
> reset              rm                 rmdir              saveenv
> sedit              sh                 sha1sum            sha256sum
> sleep              source             test               tftp
> time               timeout            true               umount
> uncompress         unprotect          version            net.nameserver=
> net.domainname=    cs0.baudrate=      cs0.active=        cs1.active=
> cs1.ip=            cs1.port=
> barebox:/ $<TAB>
> $net.nameserver     $net.domainname     $cs0.baudrate
> $cs0.active         $cs1.active         $cs1.ip
> $cs1.port           $net.nameserver     $net.domainname
> $cs0.baudrate       $cs0.active         $cs1.active
> $cs1.ip             $cs1.port
> barebox:/ $
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  common/complete.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/complete.c b/common/complete.c
> index 0b03d7c..0780888 100644
> --- a/common/complete.c
> +++ b/common/complete.c
> @@ -272,7 +272,7 @@ static char* cmd_complete_lookup(struct string_list *sl, char *instr)
>  {
>        struct command *cmdtp;
>        int len;
> -       int ret = 1;
> +       int ret = COMPLETE_END;
>        char *res = NULL;
>
>        for_each_command(cmdtp) {
> --
> 1.7.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox