device parameter patches

device parameter patches

[Sascha Hauer]

Two small patches...

Sascha

----------------------------------------------------------------
Sascha Hauer (2):
      parameter: return empty string for unset parameters
      parameter: remove unused struct member

 include/param.h |    1 -
 lib/parameter.c |    2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 1/2] parameter: return empty string for unset parameters

[Sascha Hauer]

Currently we return NULL for unset parameters. As we can't set them
back to NULL once set this is not very consistent. Return an empty
string instead.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 lib/parameter.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/parameter.c b/lib/parameter.c
index baf7720..c75c21e 100644
--- a/lib/parameter.c
+++ b/lib/parameter.c
@@ -135,7 +135,7 @@ int dev_param_set_generic(struct device_d *dev, struct param_d *p,
 
 static const char *param_get_generic(struct device_d *dev, struct param_d *p)
 {
-	return p->value;
+	return p->value ? p->value : "";
 }
 
 static struct param_d *__dev_add_param(struct device_d *dev, const char *name,
-- 
1.7.10


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/2] parameter: remove unused struct member

[Sascha Hauer]

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 include/param.h |    1 -
 1 file changed, 1 deletion(-)

diff --git a/include/param.h b/include/param.h
index e7b66a4..a855102 100644
--- a/include/param.h
+++ b/include/param.h
@@ -14,7 +14,6 @@ struct param_d {
 	int (*set)(struct device_d *, struct param_d *param, const char *val);
 	unsigned int flags;
 	char *name;
-	struct param_d *next;
 	char *value;
 	struct list_head list;
 };
-- 
1.7.10


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

device parameter patches

[Sascha Hauer]

Some device parameter patches.

Sascha

----------------------------------------------------------------
Sascha Hauer (3):
      param: make return value of param getter function const
      devinfo: use accessor function for parameters
      dev_add_param: check if param exists already

 drivers/base/driver.c |    2 +-
 include/param.h       |    6 +++---
 lib/parameter.c       |   14 +++++++++-----
 3 files changed, 13 insertions(+), 9 deletions(-)

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox