* [PATCH 1/2] Setup UART-pads via iomux interface
@ 2012-06-21 8:05 Alexander Shiyan
2012-06-21 8:05 ` [PATCH 2/2] mx51-pdk: Move lowlevel_init before UART initialization Alexander Shiyan
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shiyan @ 2012-06-21 8:05 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boards/eukrea_cpuimx51/eukrea_cpuimx51.c | 11 ++++++-----
arch/arm/boards/freescale-mx51-pdk/board.c | 12 +++++++-----
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boards/eukrea_cpuimx51/eukrea_cpuimx51.c b/arch/arm/boards/eukrea_cpuimx51/eukrea_cpuimx51.c
index 3cc7a72..35c114d 100644
--- a/arch/arm/boards/eukrea_cpuimx51/eukrea_cpuimx51.c
+++ b/arch/arm/boards/eukrea_cpuimx51/eukrea_cpuimx51.c
@@ -53,6 +53,11 @@ struct imx_nand_platform_data nand_info = {
};
static iomux_v3_cfg_t eukrea_cpuimx51_pads[] = {
+ /* UART1 */
+ MX51_PAD_UART1_RXD__UART1_RXD,
+ MX51_PAD_UART1_TXD__UART1_TXD,
+ MX51_PAD_UART1_RTS__UART1_RTS,
+ MX51_PAD_UART1_CTS__UART1_CTS,
/* FEC */
MX51_PAD_DISP2_DAT1__FEC_RX_ER,
MX51_PAD_DISP2_DAT15__FEC_TDATA0,
@@ -141,12 +146,8 @@ static int eukrea_cpuimx51_console_init(void)
imx51_init_lowlevel(800);
- writel(0, 0x73fa8228);
- writel(0, 0x73fa822c);
- writel(0, 0x73fa8230);
- writel(0, 0x73fa8234);
-
imx51_add_uart0();
+
return 0;
}
diff --git a/arch/arm/boards/freescale-mx51-pdk/board.c b/arch/arm/boards/freescale-mx51-pdk/board.c
index 0bb2ffe..9ec331a 100644
--- a/arch/arm/boards/freescale-mx51-pdk/board.c
+++ b/arch/arm/boards/freescale-mx51-pdk/board.c
@@ -48,6 +48,12 @@ static struct fec_platform_data fec_info = {
};
static iomux_v3_cfg_t f3s_pads[] = {
+ /* UART1 */
+ MX51_PAD_UART1_RXD__UART1_RXD,
+ MX51_PAD_UART1_TXD__UART1_TXD,
+ MX51_PAD_UART1_RTS__UART1_RTS,
+ MX51_PAD_UART1_CTS__UART1_CTS,
+ /* FEC */
MX51_PAD_EIM_EB2__FEC_MDIO,
MX51_PAD_EIM_EB3__FEC_RDATA1,
MX51_PAD_EIM_CS2__FEC_RDATA2,
@@ -268,12 +274,8 @@ static int f3s_console_init(void)
{
mxc_iomux_v3_setup_multiple_pads(f3s_pads, ARRAY_SIZE(f3s_pads));
- writel(0, 0x73fa8228);
- writel(0, 0x73fa822c);
- writel(0, 0x73fa8230);
- writel(0, 0x73fa8234);
-
imx51_add_uart0();
+
return 0;
}
--
1.7.3.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] mx51-pdk: Move lowlevel_init before UART initialization
2012-06-21 8:05 [PATCH 1/2] Setup UART-pads via iomux interface Alexander Shiyan
@ 2012-06-21 8:05 ` Alexander Shiyan
2012-06-21 9:41 ` Sascha Hauer
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shiyan @ 2012-06-21 8:05 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boards/freescale-mx51-pdk/board.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/boards/freescale-mx51-pdk/board.c b/arch/arm/boards/freescale-mx51-pdk/board.c
index 9ec331a..18c21ce 100644
--- a/arch/arm/boards/freescale-mx51-pdk/board.c
+++ b/arch/arm/boards/freescale-mx51-pdk/board.c
@@ -246,7 +246,6 @@ static int f3s_devices_init(void)
babbage_power_init();
console_flush();
- imx51_init_lowlevel(800);
clock_notifier_call_chain();
imx51_iim_register_fec_ethaddr();
@@ -274,6 +273,8 @@ static int f3s_console_init(void)
{
mxc_iomux_v3_setup_multiple_pads(f3s_pads, ARRAY_SIZE(f3s_pads));
+ imx51_init_lowlevel(800);
+
imx51_add_uart0();
return 0;
--
1.7.3.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mx51-pdk: Move lowlevel_init before UART initialization
2012-06-21 8:05 ` [PATCH 2/2] mx51-pdk: Move lowlevel_init before UART initialization Alexander Shiyan
@ 2012-06-21 9:41 ` Sascha Hauer
2012-06-21 10:25 ` Re[2]: " Alexander Shiyan
0 siblings, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2012-06-21 9:41 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On Thu, Jun 21, 2012 at 12:05:03PM +0400, Alexander Shiyan wrote:
<please put the reason of this change here>
Sascha
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boards/freescale-mx51-pdk/board.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boards/freescale-mx51-pdk/board.c b/arch/arm/boards/freescale-mx51-pdk/board.c
> index 9ec331a..18c21ce 100644
> --- a/arch/arm/boards/freescale-mx51-pdk/board.c
> +++ b/arch/arm/boards/freescale-mx51-pdk/board.c
> @@ -246,7 +246,6 @@ static int f3s_devices_init(void)
> babbage_power_init();
>
> console_flush();
> - imx51_init_lowlevel(800);
> clock_notifier_call_chain();
>
> imx51_iim_register_fec_ethaddr();
> @@ -274,6 +273,8 @@ static int f3s_console_init(void)
> {
> mxc_iomux_v3_setup_multiple_pads(f3s_pads, ARRAY_SIZE(f3s_pads));
>
> + imx51_init_lowlevel(800);
> +
> imx51_add_uart0();
>
> return 0;
> --
> 1.7.3.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re[2]: [PATCH 2/2] mx51-pdk: Move lowlevel_init before UART initialization
2012-06-21 9:41 ` Sascha Hauer
@ 2012-06-21 10:25 ` Alexander Shiyan
2012-06-21 18:49 ` Sascha Hauer
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shiyan @ 2012-06-21 10:25 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
Hello.
Thu, 21 Jun 2012 11:41:17 +0200 от Sascha Hauer <s.hauer@pengutronix.de>:
> On Thu, Jun 21, 2012 at 12:05:03PM +0400, Alexander Shiyan wrote:
>
> <please put the reason of this change here>
...
> > @@ -274,6 +273,8 @@ static int f3s_console_init(void)
> > {
> > mxc_iomux_v3_setup_multiple_pads(f3s_pads, ARRAY_SIZE(f3s_pads));
> >
> > + imx51_init_lowlevel(800);
> > +
> > imx51_add_uart0();
> >
> > return 0;
...
This is just bringing the initialization for all mx51-based boards to the same format.
You can just reject this patch and apply only part 1.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mx51-pdk: Move lowlevel_init before UART initialization
2012-06-21 10:25 ` Re[2]: " Alexander Shiyan
@ 2012-06-21 18:49 ` Sascha Hauer
0 siblings, 0 replies; 5+ messages in thread
From: Sascha Hauer @ 2012-06-21 18:49 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On Thu, Jun 21, 2012 at 02:25:07PM +0400, Alexander Shiyan wrote:
> Hello.
>
> Thu, 21 Jun 2012 11:41:17 +0200 от Sascha Hauer <s.hauer@pengutronix.de>:
> > On Thu, Jun 21, 2012 at 12:05:03PM +0400, Alexander Shiyan wrote:
> >
> > <please put the reason of this change here>
> ...
> > > @@ -274,6 +273,8 @@ static int f3s_console_init(void)
> > > {
> > > mxc_iomux_v3_setup_multiple_pads(f3s_pads, ARRAY_SIZE(f3s_pads));
> > >
> > > + imx51_init_lowlevel(800);
> > > +
> > > imx51_add_uart0();
> > >
> > > return 0;
> ...
>
> This is just bringing the initialization for all mx51-based boards to the same format.
> You can just reject this patch and apply only part 1.
Ok, did that.
Thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-21 18:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-21 8:05 [PATCH 1/2] Setup UART-pads via iomux interface Alexander Shiyan
2012-06-21 8:05 ` [PATCH 2/2] mx51-pdk: Move lowlevel_init before UART initialization Alexander Shiyan
2012-06-21 9:41 ` Sascha Hauer
2012-06-21 10:25 ` Re[2]: " Alexander Shiyan
2012-06-21 18:49 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox