mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM/imx/pcm043: increase size of "self" partition
@ 2012-07-27  8:41 Uwe Kleine-König
  2012-07-27  9:26 ` Sascha Hauer
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2012-07-27  8:41 UTC (permalink / raw)
  To: barebox

A barebox image generated from pcm043_defconfig doesn't fit into the
0x40000 byte sized self partition as of

	v2012.07.0-153-g14c8c60 (command: add missing EXPORT_SYMBOL for find_cmd)

.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/boards/pcm043/pcm043.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
index b1bf8ef..7ccd973 100644
--- a/arch/arm/boards/pcm043/pcm043.c
+++ b/arch/arm/boards/pcm043/pcm043.c
@@ -153,15 +153,15 @@ static int imx35_devices_init(void)
 	if ((reg & 0xc00) == 0x800) {   /* reset mode: external boot */
 		switch ( (reg >> 25) & 0x3) {
 		case 0x01:              /* NAND is the source */
-			devfs_add_partition("nand0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self_raw");
+			devfs_add_partition("nand0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self_raw");
 			dev_add_bb_dev("self_raw", "self0");
-			devfs_add_partition("nand0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");
+			devfs_add_partition("nand0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");
 			dev_add_bb_dev("env_raw", "env0");
 			break;
 
 		case 0x00:              /* NOR is the source */
-			devfs_add_partition("nor0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
-			devfs_add_partition("nor0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
+			devfs_add_partition("nor0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
+			devfs_add_partition("nor0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
 			protect_file("/dev/env0", 1);
 			break;
 		}
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM/imx/pcm043: increase size of "self" partition
  2012-07-27  8:41 [PATCH] ARM/imx/pcm043: increase size of "self" partition Uwe Kleine-König
@ 2012-07-27  9:26 ` Sascha Hauer
  2012-07-27 11:03 ` Jan Weitzel
  2012-07-30 11:11 ` [PATCH v2] " Uwe Kleine-König
  2 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2012-07-27  9:26 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: barebox

On Fri, Jul 27, 2012 at 10:41:24AM +0200, Uwe Kleine-König wrote:
> A barebox image generated from pcm043_defconfig doesn't fit into the
> 0x40000 byte sized self partition as of
> 
> 	v2012.07.0-153-g14c8c60 (command: add missing EXPORT_SYMBOL for find_cmd)

You also must adjust the size in the defconfig.

Sascha

> 
> .
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm/boards/pcm043/pcm043.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
> index b1bf8ef..7ccd973 100644
> --- a/arch/arm/boards/pcm043/pcm043.c
> +++ b/arch/arm/boards/pcm043/pcm043.c
> @@ -153,15 +153,15 @@ static int imx35_devices_init(void)
>  	if ((reg & 0xc00) == 0x800) {   /* reset mode: external boot */
>  		switch ( (reg >> 25) & 0x3) {
>  		case 0x01:              /* NAND is the source */
> -			devfs_add_partition("nand0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self_raw");
> +			devfs_add_partition("nand0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self_raw");
>  			dev_add_bb_dev("self_raw", "self0");
> -			devfs_add_partition("nand0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");
> +			devfs_add_partition("nand0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");
>  			dev_add_bb_dev("env_raw", "env0");
>  			break;
>  
>  		case 0x00:              /* NOR is the source */
> -			devfs_add_partition("nor0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
> -			devfs_add_partition("nor0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
> +			devfs_add_partition("nor0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
> +			devfs_add_partition("nor0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
>  			protect_file("/dev/env0", 1);
>  			break;
>  		}
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM/imx/pcm043: increase size of "self" partition
  2012-07-27  8:41 [PATCH] ARM/imx/pcm043: increase size of "self" partition Uwe Kleine-König
  2012-07-27  9:26 ` Sascha Hauer
@ 2012-07-27 11:03 ` Jan Weitzel
  2012-07-30 11:10   ` Uwe Kleine-König
  2012-07-30 11:11 ` [PATCH v2] " Uwe Kleine-König
  2 siblings, 1 reply; 6+ messages in thread
From: Jan Weitzel @ 2012-07-27 11:03 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: barebox

Am Freitag, den 27.07.2012, 10:41 +0200 schrieb Uwe Kleine-König:
> A barebox image generated from pcm043_defconfig doesn't fit into the
> 0x40000 byte sized self partition as of
> 
> 	v2012.07.0-153-g14c8c60 (command: add missing EXPORT_SYMBOL for find_cmd)
> 
> .
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm/boards/pcm043/pcm043.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
> index b1bf8ef..7ccd973 100644
> --- a/arch/arm/boards/pcm043/pcm043.c
> +++ b/arch/arm/boards/pcm043/pcm043.c
> @@ -153,15 +153,15 @@ static int imx35_devices_init(void)
>  	if ((reg & 0xc00) == 0x800) {   /* reset mode: external boot */
>  		switch ( (reg >> 25) & 0x3) {
>  		case 0x01:              /* NAND is the source */
> -			devfs_add_partition("nand0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self_raw");
> +			devfs_add_partition("nand0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self_raw");
What do you think about SZ_128K + SZ_256K ? Maybe SZ_512K is even
better.
Jan
>  			dev_add_bb_dev("self_raw", "self0");
> -			devfs_add_partition("nand0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");
> +			devfs_add_partition("nand0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");
>  			dev_add_bb_dev("env_raw", "env0");
>  			break;
>  
>  		case 0x00:              /* NOR is the source */
> -			devfs_add_partition("nor0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
> -			devfs_add_partition("nor0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
> +			devfs_add_partition("nor0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
> +			devfs_add_partition("nor0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
>  			protect_file("/dev/env0", 1);
>  			break;
>  		}



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM/imx/pcm043: increase size of "self" partition
  2012-07-27 11:03 ` Jan Weitzel
@ 2012-07-30 11:10   ` Uwe Kleine-König
  0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2012-07-30 11:10 UTC (permalink / raw)
  To: Jan Weitzel; +Cc: barebox

On Fri, Jul 27, 2012 at 01:03:30PM +0200, Jan Weitzel wrote:
> Am Freitag, den 27.07.2012, 10:41 +0200 schrieb Uwe Kleine-König:
> > A barebox image generated from pcm043_defconfig doesn't fit into the
> > 0x40000 byte sized self partition as of
> > 
> > 	v2012.07.0-153-g14c8c60 (command: add missing EXPORT_SYMBOL for find_cmd)
> > 
> > .
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  arch/arm/boards/pcm043/pcm043.c |    8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
> > index b1bf8ef..7ccd973 100644
> > --- a/arch/arm/boards/pcm043/pcm043.c
> > +++ b/arch/arm/boards/pcm043/pcm043.c
> > @@ -153,15 +153,15 @@ static int imx35_devices_init(void)
> >  	if ((reg & 0xc00) == 0x800) {   /* reset mode: external boot */
> >  		switch ( (reg >> 25) & 0x3) {
> >  		case 0x01:              /* NAND is the source */
> > -			devfs_add_partition("nand0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self_raw");
> > +			devfs_add_partition("nand0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self_raw");
> What do you think about SZ_128K + SZ_256K ? Maybe SZ_512K is even
> better.
I don't like SZ_128K + SZ_256K, which in my eyes is more ugly than a hex
constant. And using 512 kiB seems unnecessary to me. I'd like to stay
with 0x60000.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] ARM/imx/pcm043: increase size of "self" partition
  2012-07-27  8:41 [PATCH] ARM/imx/pcm043: increase size of "self" partition Uwe Kleine-König
  2012-07-27  9:26 ` Sascha Hauer
  2012-07-27 11:03 ` Jan Weitzel
@ 2012-07-30 11:11 ` Uwe Kleine-König
  2012-08-10  9:07   ` Sascha Hauer
  2 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2012-07-30 11:11 UTC (permalink / raw)
  To: barebox

A barebox image generated from pcm043_defconfig doesn't fit into the
0x40000 byte sized self partition as of

	v2012.07.0-153-g14c8c60 (command: add missing EXPORT_SYMBOL for find_cmd)

.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/boards/pcm043/env/config |    4 ++--
 arch/arm/boards/pcm043/pcm043.c   |    8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boards/pcm043/env/config b/arch/arm/boards/pcm043/env/config
index 644c7fb..c48f87c 100644
--- a/arch/arm/boards/pcm043/env/config
+++ b/arch/arm/boards/pcm043/env/config
@@ -42,10 +42,10 @@ bootargs="console=ttymxc0,115200"
 
 bootargs="$bootargs video=mx3fb:CTP-CLAA070LC0ACW"
 
-nor_parts="256k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)"
+nor_parts="384k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)"
 rootfs_mtdblock_nor=3
 
-nand_parts="256k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)"
+nand_parts="384k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)"
 rootfs_mtdblock_nand=7
 
 # set a fancy prompt (if support is compiled in)
diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
index b1bf8ef..7ccd973 100644
--- a/arch/arm/boards/pcm043/pcm043.c
+++ b/arch/arm/boards/pcm043/pcm043.c
@@ -153,15 +153,15 @@ static int imx35_devices_init(void)
 	if ((reg & 0xc00) == 0x800) {   /* reset mode: external boot */
 		switch ( (reg >> 25) & 0x3) {
 		case 0x01:              /* NAND is the source */
-			devfs_add_partition("nand0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self_raw");
+			devfs_add_partition("nand0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self_raw");
 			dev_add_bb_dev("self_raw", "self0");
-			devfs_add_partition("nand0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");
+			devfs_add_partition("nand0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");
 			dev_add_bb_dev("env_raw", "env0");
 			break;
 
 		case 0x00:              /* NOR is the source */
-			devfs_add_partition("nor0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
-			devfs_add_partition("nor0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
+			devfs_add_partition("nor0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
+			devfs_add_partition("nor0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
 			protect_file("/dev/env0", 1);
 			break;
 		}
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] ARM/imx/pcm043: increase size of "self" partition
  2012-07-30 11:11 ` [PATCH v2] " Uwe Kleine-König
@ 2012-08-10  9:07   ` Sascha Hauer
  0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2012-08-10  9:07 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: barebox

On Mon, Jul 30, 2012 at 01:11:53PM +0200, Uwe Kleine-König wrote:
> A barebox image generated from pcm043_defconfig doesn't fit into the
> 0x40000 byte sized self partition as of
> 
> 	v2012.07.0-153-g14c8c60 (command: add missing EXPORT_SYMBOL for find_cmd)
> 
> .
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm/boards/pcm043/env/config |    4 ++--
>  arch/arm/boards/pcm043/pcm043.c   |    8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boards/pcm043/env/config b/arch/arm/boards/pcm043/env/config
> index 644c7fb..c48f87c 100644
> --- a/arch/arm/boards/pcm043/env/config
> +++ b/arch/arm/boards/pcm043/env/config
> @@ -42,10 +42,10 @@ bootargs="console=ttymxc0,115200"
>  
>  bootargs="$bootargs video=mx3fb:CTP-CLAA070LC0ACW"
>  
> -nor_parts="256k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)"
> +nor_parts="384k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)"
>  rootfs_mtdblock_nor=3
>  
> -nand_parts="256k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)"
> +nand_parts="384k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)"
>  rootfs_mtdblock_nand=7
>  
>  # set a fancy prompt (if support is compiled in)
> diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
> index b1bf8ef..7ccd973 100644
> --- a/arch/arm/boards/pcm043/pcm043.c
> +++ b/arch/arm/boards/pcm043/pcm043.c
> @@ -153,15 +153,15 @@ static int imx35_devices_init(void)
>  	if ((reg & 0xc00) == 0x800) {   /* reset mode: external boot */
>  		switch ( (reg >> 25) & 0x3) {
>  		case 0x01:              /* NAND is the source */
> -			devfs_add_partition("nand0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self_raw");
> +			devfs_add_partition("nand0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self_raw");
>  			dev_add_bb_dev("self_raw", "self0");
> -			devfs_add_partition("nand0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");
> +			devfs_add_partition("nand0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env_raw");

Can we increase this aswell to at least 512k? 0x20000 only is a single
eraseblock.

Sascha

>  			dev_add_bb_dev("env_raw", "env0");
>  			break;
>  
>  		case 0x00:              /* NOR is the source */
> -			devfs_add_partition("nor0", 0x00000, 0x40000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
> -			devfs_add_partition("nor0", 0x40000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
> +			devfs_add_partition("nor0", 0x00000, 0x60000, DEVFS_PARTITION_FIXED, "self0"); /* ourself */
> +			devfs_add_partition("nor0", 0x60000, 0x20000, DEVFS_PARTITION_FIXED, "env0");  /* environment */
>  			protect_file("/dev/env0", 1);
>  			break;
>  		}
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-08-10  9:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-27  8:41 [PATCH] ARM/imx/pcm043: increase size of "self" partition Uwe Kleine-König
2012-07-27  9:26 ` Sascha Hauer
2012-07-27 11:03 ` Jan Weitzel
2012-07-30 11:10   ` Uwe Kleine-König
2012-07-30 11:11 ` [PATCH v2] " Uwe Kleine-König
2012-08-10  9:07   ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox