[PATCH] UBI work

[PATCH] UBI work

[Sascha Hauer]

Some UBI fixes, one to make writing to UBI devices actually work.

Sascha

----------------------------------------------------------------
Sascha Hauer (2):
      ubi: cdev->write has to return the bytes read, not 0
      ubi: align ubi writes to LEB size

 drivers/mtd/ubi/cdev.c |   35 +++++++++++++++++++++++++++--------
 1 file changed, 27 insertions(+), 8 deletions(-)

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 1/2] ubi: cdev->write has to return the bytes read, not 0

[Sascha Hauer]

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mtd/ubi/cdev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index c99b64d..6b1e432 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -78,7 +78,7 @@ static ssize_t ubi_volume_cdev_write(struct cdev* cdev, const void *buf,
 		return err;
 	}
 
-	return err;
+	return size;
 }
 
 static int ubi_volume_cdev_open(struct cdev *cdev, unsigned long flags)
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/2] ubi: align ubi writes to LEB size

[Sascha Hauer]

Otherwise incomplete LEBs are not written.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mtd/ubi/cdev.c |   33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 6b1e432..93c3491 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -8,7 +8,7 @@
 struct ubi_volume_cdev_priv {
 	struct ubi_device *ubi;
 	struct ubi_volume *vol;
-	int updating;
+	int written;
 };
 
 static ssize_t ubi_volume_cdev_read(struct cdev *cdev, void *buf, size_t size,
@@ -63,13 +63,12 @@ static ssize_t ubi_volume_cdev_write(struct cdev* cdev, const void *buf,
 	struct ubi_device *ubi = priv->ubi;
 	int err;
 
-	if (!priv->updating) {
-		err = ubi_start_update(ubi, vol, 16*1024*1024);
+	if (!priv->written) {
+		err = ubi_start_update(ubi, vol, vol->used_bytes);
 		if (err < 0) {
 			printf("Cannot start volume update\n");
 			return err;
 		}
-		priv->updating = 1;
 	}
 
 	err = ubi_more_update_data(ubi, vol, buf, size);
@@ -78,6 +77,8 @@ static ssize_t ubi_volume_cdev_write(struct cdev* cdev, const void *buf,
 		return err;
 	}
 
+	priv->written += size;
+
 	return size;
 }
 
@@ -85,7 +86,7 @@ static int ubi_volume_cdev_open(struct cdev *cdev, unsigned long flags)
 {
 	struct ubi_volume_cdev_priv *priv = cdev->priv;
 
-	priv->updating = 0;
+	priv->written = 0;
 
 	return 0;
 }
@@ -97,7 +98,25 @@ static int ubi_volume_cdev_close(struct cdev *cdev)
 	struct ubi_device *ubi = priv->ubi;
 	int err;
 
-	if (priv->updating) {
+	if (priv->written) {
+		int remaining = vol->usable_leb_size -
+				(priv->written % vol->usable_leb_size);
+
+		if (remaining) {
+			void *buf = xzalloc(remaining);
+
+			memset(buf, 0xff, remaining);
+
+			err = ubi_more_update_data(ubi, vol, buf, remaining);
+
+			free(buf);
+
+			if (err < 0) {
+				printf("Couldnt or partially wrote data \n");
+				return err;
+			}
+		}
+
 		err = ubi_finish_update(ubi, vol);
 		if (err)
 			return err;
@@ -126,7 +145,7 @@ static loff_t ubi_volume_cdev_lseek(struct cdev *cdev, loff_t ofs)
 	struct ubi_volume_cdev_priv *priv = cdev->priv;
 
 	/* We can only update ubi volumes sequentially */
-	if (priv->updating)
+	if (priv->written)
 		return -EINVAL;
 
 	return ofs;
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox